-
Notifications
You must be signed in to change notification settings - Fork 898
feat(desktop): add v1 import intro page + fix preset import #4151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...enderer/routes/_authenticated/components/V1ImportModal/components/IntroPage/IntroPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| export function IntroPage() { | ||
| return ( | ||
| <div className="flex h-[454px] flex-col items-center justify-center bg-background px-14 text-center"> | ||
| <div className="text-2xl font-semibold text-foreground"> | ||
| Let's get you started | ||
| </div> | ||
| <p className="mt-3 max-w-md text-sm text-muted-foreground"> | ||
| Let's get your workspaces and projects ported over. Terminal sessions | ||
| won't be carried over, but you can still access v1 at any time. | ||
| </p> | ||
| </div> | ||
| ); | ||
| } |
1 change: 1 addition & 0 deletions
1
...src/renderer/routes/_authenticated/components/V1ImportModal/components/IntroPage/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { IntroPage } from "./IntroPage"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
importedNamesis built from all v2 preset names, including builtins imported under their display labels (e.g."Claude Code"). If a user has a custom v1 preset whose name happens to match a builtin's display label,importedNames.has(v2Name)returnstrueand the row is permanently stuck as "Imported" — even though no custom preset with that name was ever actually imported. NarrowingimportedNamesto only presets whereagentIdis absent would avoid the collision.Prompt To Fix With AI