Skip to content

feat(desktop): remove skip-all onboarding affordance #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AviPeltz merged 18 commits into from
May 6, 2026
Merged

feat(desktop): remove skip-all onboarding affordance #4113

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6c251f7
feat(desktop): remove skip-all onboarding affordance
AviPeltz May 5, 2026
7b235ee
feat(desktop): unify onboarding step layout and stack providers
AviPeltz May 5, 2026
ffe52dd
feat(desktop): auto-capture OpenAI OAuth callback via loopback
AviPeltz May 6, 2026
c6770aa
fix(desktop): route back to providers page after reconnect completes
AviPeltz May 6, 2026
f141360
fix(desktop): bind OAuth loopback to redirect_uri host, not hardcoded…
AviPeltz May 6, 2026
d928d2f
feat(desktop): use real app icon on connect-provider pages
AviPeltz May 6, 2026
65103ae
style(desktop): round superset icon on connect pages to match provide…
AviPeltz May 6, 2026
5e9fd20
style(desktop): scale superset icon so it fills the circular crop
AviPeltz May 6, 2026
fbf5cfa
style(desktop): use inline SupersetIcon SVG on connect pages
AviPeltz May 6, 2026
57eb759
feat(desktop): use docs logo.png for connect provider pages
AviPeltz May 6, 2026
e8c5e10
style(desktop): square off provider logos to match superset icon shape
AviPeltz May 6, 2026
f3beca3
style(desktop): match superset icon size and squared border container
AviPeltz May 6, 2026
9ce8c98
style(desktop): bump superset logo scale so brackets match codex/clau…
AviPeltz May 6, 2026
d5c9b41
style(desktop): leave superset logo at natural size, bump codex/claud…
AviPeltz May 6, 2026
23bdec3
style(desktop): use real superset brand glyph for setup tiles
AviPeltz May 6, 2026
fb31f5d
Merge remote-tracking branch 'origin/main' into v2-onboarding-flow-re…
AviPeltz May 6, 2026
fb945dc
feat(desktop): selectable worktree import in onboarding
AviPeltz May 6, 2026
a3bb042
refactor(desktop): share external-worktree filter between query and i…
AviPeltz May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/desktop/src/renderer/routes/_authenticated/setup/adopt-worktrees/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,12 @@ function AdoptWorktreesContent({

<div className="flex w-[273px] flex-col gap-2 self-center">
{nothingToAdopt ? (
<SetupButton onClick={onFinish}>Continue</SetupButton>
<>
<SetupButton onClick={onFinish}>Continue</SetupButton>
<SetupButton variant="link" onClick={onSkip}>
Skip for now
</SetupButton>
</>
) : (
<>
<SetupButton
Expand Down
19 changes: 1 addition & 18 deletions ...renderer/routes/_authenticated/setup/components/OnboardingProgress/OnboardingProgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,9 @@ export function OnboardingProgress() {
const currentStep = useOnboardingStore((s) => s.currentStep);
const completed = useOnboardingStore((s) => s.completed);
const skipped = useOnboardingStore((s) => s.skipped);
const skipAll = useOnboardingStore((s) => s.skipAll);
const backTo = useSetupChromeStore((s) => s.backTo);
const currentIdx = ONBOARDING_STEP_ORDER.indexOf(currentStep);

const handleSkipAll = () => {
skipAll();
navigate({ to: "/welcome", replace: true });
};

const pillBase =
"inline-flex h-7 items-center gap-1.5 rounded-full border px-3 text-[12px] font-medium transition-colors";

Expand Down Expand Up @@ -106,18 +100,7 @@ export function OnboardingProgress() {
})}
</div>

<div className="flex items-center justify-end">
<button
type="button"
onClick={handleSkipAll}
className={cn(
pillBase,
"border-transparent text-[#a8a5a3] hover:bg-white/5 hover:text-[#eae8e6]",
)}
>
Skip onboarding
</button>
</div>
<div className="flex items-center justify-end" />

@greptile-apps greptile-apps Bot May 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty layout spacer div

The right-hand column is now empty after the button removal. Its only job is to balance the grid-cols-[1fr_auto_1fr] grid so the step pills remain visually centered. A brief comment would make this intentional spacer obvious to future readers; alternatively, the Tailwind classes on the div (flex items-center justify-end) can be dropped since there is no longer any content to align.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/desktop/src/renderer/routes/_authenticated/setup/components/OnboardingProgress/OnboardingProgress.tsx
Line: 103

Comment:
**Empty layout spacer div**

The right-hand column is now empty after the button removal. Its only job is to balance the `grid-cols-[1fr_auto_1fr]` grid so the step pills remain visually centered. A brief comment would make this intentional spacer obvious to future readers; alternatively, the Tailwind classes on the div (`flex items-center justify-end`) can be dropped since there is no longer any content to align.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

</div>
);
}
3 changes: 3 additions & 0 deletions apps/desktop/src/renderer/routes/_authenticated/setup/gh-cli/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ function OnboardingGhCliPage() {

<div className="flex w-[273px] flex-col gap-2 self-center">
<SetupButton onClick={handleContinue}>Continue</SetupButton>
<SetupButton variant="link" onClick={handleSkip}>
Skip for now
</SetupButton>
</div>
</StepShell>
);
Expand Down
Loading
Loading