-
Notifications
You must be signed in to change notification settings - Fork 962
feat(desktop): toggle to disable adaptive keyboard-layout mapping #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export { useHotkeyOverridesStore } from "./hotkeyOverridesStore"; | ||
| export { useKeyboardPreferencesStore } from "./keyboardPreferencesStore"; |
28 changes: 28 additions & 0 deletions
28
apps/desktop/src/renderer/hotkeys/stores/keyboardPreferencesStore.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { create } from "zustand"; | ||
| import { createJSONStorage, persist } from "zustand/middleware"; | ||
|
|
||
| interface KeyboardPreferencesState { | ||
| /** Opt-in: when true, logical bindings are translated through the OS | ||
| * keyboard layout — e.g. `⌘Z` dispatches to physical KeyY on QWERTZ. | ||
| * Defaults to false so bindings dispatch and display as if on US-ANSI | ||
| * regardless of the current input source. */ | ||
| adaptiveLayoutEnabled: boolean; | ||
| setAdaptiveLayoutEnabled: (enabled: boolean) => void; | ||
| } | ||
|
|
||
| export const useKeyboardPreferencesStore = create<KeyboardPreferencesState>()( | ||
| persist( | ||
| (set) => ({ | ||
| adaptiveLayoutEnabled: false, | ||
| setAdaptiveLayoutEnabled: (enabled) => | ||
| set({ adaptiveLayoutEnabled: enabled }), | ||
| }), | ||
| { | ||
| name: "keyboard-preferences", | ||
| storage: createJSONStorage(() => localStorage), | ||
| partialize: (state) => ({ | ||
| adaptiveLayoutEnabled: state.adaptiveLayoutEnabled, | ||
| }), | ||
| }, | ||
| ), | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useActiveLayoutMapalways subscribes touseKeyboardLayoutStore, so every keyboard-layout change (e.g. user switching input sources) triggers a re-render of everyuseHotkeyDisplay/useFormatBindingconsumer even when adaptive layout is disabled and the return value is alwaysnull. Moving the selector condition inside the store subscription avoids these phantom re-renders.Prompt To Fix With AI