Skip to content

fix(ci): drop redundant better-sqlite3 rebuild in CLI Linux build #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
May 4, 2026
Merged

fix(ci): drop redundant better-sqlite3 rebuild in CLI Linux build #4049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/build-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,18 @@ jobs:
# against node-pty's compile-from-source path on Linux (node-pty
# ships no Linux prebuilds). Skip scripts at install, then rebuild
# native deps explicitly via npm/node-gyp.
#
# better-sqlite3 is intentionally NOT rebuilt here: build-dist.ts's
# fixNativeBinariesForNode() unconditionally downloads the matching
# Node-ABI prebuild from GitHub releases and overwrites the .node
# file. Running `npm rebuild better-sqlite3` here is redundant work
# and a CI flake source — its `prebuild-install || node-gyp rebuild`
# install script intermittently truncates the prebuild download or
# leaves partial state that breaks the gyp fallback on linux-x64.
set -euo pipefail
bun install --frozen --ignore-scripts
PTY_DIR=$(ls -d node_modules/.bun/node-pty@*/node_modules/node-pty)
(cd "$PTY_DIR" && npx --yes node-gyp rebuild)
npm rebuild better-sqlite3
npm rebuild @parcel/watcher

- name: Install dependencies (macOS)
Expand Down
Loading