Skip to content

feat(desktop): enable v2 by default in dev#3883

Merged
Kitenite merged 1 commit intomainfrom
enable-v2-default
Apr 29, 2026
Merged

feat(desktop): enable v2 by default in dev#3883
Kitenite merged 1 commit intomainfrom
enable-v2-default

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Apr 29, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Summary by cubic

Turn on v2 Cloud by default in development. In NODE_ENV=development, useIsV2CloudEnabled returns isV2CloudEnabled: true and isRemoteV2Enabled: true, bypassing the PostHog flag and local opt-in (no change in production).

Written for commit db1ff85. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Chores
    • Added development environment override for v2 cloud feature testing, enabling developers to evaluate v2 cloud functionality during local development without relying on feature flag configuration.

@Kitenite Kitenite merged commit 9bf4f9b into main Apr 29, 2026
5 of 6 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b526ccef-5d20-46d6-9000-9e452c279d31

📥 Commits

Reviewing files that changed from the base of the PR and between 07f2344 and db1ff85.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/hooks/useIsV2CloudEnabled.ts

📝 Walkthrough

Walkthrough

Adds a development environment override to the useIsV2CloudEnabled hook that unconditionally returns true for v2 cloud enablement flags when NODE_ENV is set to "development", bypassing PostHog evaluation and local opt-in store logic.

Changes

Cohort / File(s) Summary
Development Override
apps/desktop/src/renderer/hooks/useIsV2CloudEnabled.ts
Added conditional check to return true for v2 cloud enablement and remote v2 flags during development environment, allowing developers to test v2 cloud features without feature flag or local opt-in requirements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A dev override hops into view,
When NODE_ENV is "dev," v2 turns true,
No flags to check, no stores to consult,
Just rabbit-fast testing—a feature-dev result! 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enable-v2-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 3/8 reviews remaining, refill in 30 minutes and 22 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

holt added a commit to holt/superset that referenced this pull request Apr 30, 2026
The upstream change at superset-sh#3883 force-enables v2 in dev mode, but v2
requires Superset cloud auth to start the host-service. For local
development without a cloud account, this hides v1 workspaces and
blocks usage entirely. Restore the original PostHog flag + opt-in
gate so v1 remains accessible by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant