Skip to content

fix(desktop): claim TERM_PROGRAM=kitty in v1 terminal#3882

Merged
Kitenite merged 1 commit into
mainfrom
debug-superset-terminal-v
Apr 29, 2026
Merged

fix(desktop): claim TERM_PROGRAM=kitty in v1 terminal#3882
Kitenite merged 1 commit into
mainfrom
debug-superset-terminal-v

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Apr 29, 2026

Mirrors the host-service v2 path so chat TUIs (claude-code et al.) parse kitty CSI-u sequences from xterm.js. v1 already enables kittyKeyboard in the renderer; the env claim makes consumers honor it.

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Summary by cubic

Set TERM_PROGRAM to kitty in the desktop v1 terminal so TUIs correctly parse kitty CSI‑u keyboard sequences from xterm.js. Aligns v1 behavior with the host-service v2 path.

  • Bug Fixes
    • Export TERM_PROGRAM=kitty in buildTerminalEnv.
    • Update test to expect TERM_PROGRAM as kitty.

Written for commit 0d0781a. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Fixed terminal environment configuration to correctly identify the terminal program as "kitty" in spawned shell processes.

Mirrors the host-service v2 path so chat TUIs (claude-code et al.)
parse kitty CSI-u sequences from xterm.js. v1 already enables
kittyKeyboard in the renderer; the env claim makes consumers honor it.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c53b60f-0824-4d31-885f-1f0cdd5e19ba

📥 Commits

Reviewing files that changed from the base of the PR and between 24a07cd and 0d0781a.

📒 Files selected for processing (2)
  • apps/desktop/src/main/lib/terminal/env.test.ts
  • apps/desktop/src/main/lib/terminal/env.ts

📝 Walkthrough

Walkthrough

The TERM_PROGRAM environment variable passed to spawned terminal processes is changed from "Superset" to "kitty" in the implementation, with the corresponding test assertion updated to reflect this new expected value.

Changes

Cohort / File(s) Summary
Terminal Environment Configuration
apps/desktop/src/main/lib/terminal/env.ts, apps/desktop/src/main/lib/terminal/env.test.ts
Updated TERM_PROGRAM environment variable from "Superset" to "kitty" in both the implementation and its test assertion. All other terminal environment settings remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker-twitch brings joy today,
Superset fades, Kitty's here to stay!
TERM_PROGRAM purrs with a feline name,
Shells and terminals celebrate the same! 🐱

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch debug-superset-terminal-v

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 4/8 reviews remaining, refill in 29 minutes and 33 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 07f2344 into main Apr 29, 2026
5 of 7 checks passed
@Kitenite Kitenite deleted the debug-superset-terminal-v branch April 29, 2026 23:29
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant