fix(desktop): give v2 chat pane full width#3859
Conversation
The v2 ChatPaneInterface root sat inside PaneContent's row-direction flex with no width directive, so it sized to its intrinsic content and the chat appeared smushed. Add w-full to match every other v2 pane; also restore w-full on the SessionSelector trigger button.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo styling updates to ChatPane components add Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 5/8 reviews remaining, refill in 17 minutes and 7 seconds.Comment |
Greptile SummaryTwo one-line Tailwind fixes restore full-width layout for the v2 chat pane: Confidence Score: 5/5Safe to merge — two isolated Tailwind class additions with no logic changes. Both changes are single-class additions that restore intended layout behaviour. No logic, state, or data-flow is touched, and no issues were found. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/ChatPane/components/WorkspaceChatInterface/ChatPaneInterface.tsx | Adds w-full to the root <div> of ChatPaneInterface so it fills PaneContent's flex container width instead of collapsing to intrinsic size. |
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/ChatPane/components/SessionSelector/SessionSelector.tsx | Restores w-full on the DropdownMenuTrigger button that was present in v1 but lost during the v2 port, ensuring the session selector fills the header bar width. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
PC["PaneContent\n(flex-row container)"]
CPI["ChatPaneInterface\n(+w-full added)"]
CML["ChatMessageList"]
SS["SessionSelector trigger button\n(+w-full restored)"]
PE["PromptEditor / Composer"]
PC --> CPI
CPI --> CML
CPI --> SS
CPI --> PE
Reviews (1): Last reviewed commit: "fix(desktop): give v2 chat pane full wid..." | Re-trigger Greptile
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
ChatPaneInterfaceroot sat insidePaneContent's row-direction flex with no width directive, so it sized to its intrinsic content and the chat appeared smushed. Addedw-fullto match every other v2 pane (TerminalPane, FilePane, etc.).w-fullon the v2SessionSelectortrigger button — present in v1 but dropped in the port.Test plan
Summary by cubic
Fixes the v2 chat pane width so the message list, composer, and session selector span the full pane. Prevents the smushed layout and clipping when panes are split or resized.
w-fullto theChatPaneInterfaceroot inside the row-direction flex.w-fullon theSessionSelectortrigger button.Written for commit 5a9372f. Summary will update on new commits. Review in cubic
Summary by CodeRabbit