fix(desktop): keep diff file header items left-aligned on wrap#3858
Conversation
The v2 diff file header used `justify-between` with `flex-wrap`, so when the action cluster wrapped to a second row at narrow widths, the remaining chevron, status indicator, and file badge spread out across the first row with large gaps between them. Removing `justify-between` keeps those items tight on the left while `ml-auto` on the action div still anchors it to the right when it wraps.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Tailwind styling in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 10 minutes and 10 seconds.Comment |
Greptile SummaryRemoves Confidence Score: 5/5Safe to merge — minimal, targeted Tailwind class removal with no logic changes. The only change is dropping No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/DiffPane/components/DiffFileHeader/DiffFileHeader.tsx | Single-class removal of justify-between; ml-auto on the action cluster preserves right-alignment on wide viewports while fixing the left-spread bug on wrap. |
Reviews (1): Last reviewed commit: "fix(desktop): keep diff file header item..." | Re-trigger Greptile
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
justify-betweenwithflex-wrap. When the action cluster (additions count, Viewed checkbox, eye/copy/discard buttons) wrapped to a second row at narrow widths, the remaining chevron, status indicator, and file badge spread out across the first row with large gaps between them.justify-betweenso those items stay tight on the left;ml-autoon the action div still pushes it to the right when it wraps to row 2.Test plan
Summary by cubic
Fixes the diff file header layout so items stay left-aligned when the actions wrap on narrow widths, removing awkward gaps. Removes
justify-betweenfrom the header container;ml-autostill pushes the action group right when space allows.justify-betweenon the flex container.Written for commit cc4bfa1. Summary will update on new commits. Review in cubic
Summary by CodeRabbit