-
Notifications
You must be signed in to change notification settings - Fork 965
feat(desktop): persist last project + base branch in v2 new-workspace modal #3844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dc60207
feat(desktop): persist last project + base branch in v2 workspace modal
Kitenite 1a1a20e
feat(desktop): also persist last selected device in v2 workspace modal
Kitenite 1dde430
refactor(desktop): use zustand persist store for v2 workspace defaults
Kitenite 82ba7bb
fix(desktop): shape-validate persisted lastHostTarget before applying
Kitenite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
apps/desktop/src/renderer/stores/v2-workspace-create-defaults.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { create } from "zustand"; | ||
| import { devtools, persist } from "zustand/middleware"; | ||
|
|
||
| export type V2WorkspaceCreateBaseBranchSource = "local" | "remote-tracking"; | ||
|
|
||
| export interface V2WorkspaceCreateBaseBranchDefault { | ||
| branchName: string; | ||
| source: V2WorkspaceCreateBaseBranchSource; | ||
| } | ||
|
|
||
| export type V2WorkspaceCreateHostTarget = | ||
| | { kind: "local" } | ||
| | { kind: "host"; hostId: string }; | ||
|
|
||
| interface V2WorkspaceCreateDefaultsState { | ||
| lastProjectId: string | null; | ||
| baseBranchesByProjectId: Record<string, V2WorkspaceCreateBaseBranchDefault>; | ||
| lastHostTarget: V2WorkspaceCreateHostTarget | null; | ||
|
|
||
| setLastProjectId: (projectId: string | null) => void; | ||
| setBaseBranchDefault: ( | ||
| projectId: string, | ||
| branchName: string, | ||
| source: V2WorkspaceCreateBaseBranchSource, | ||
| ) => void; | ||
| clearBaseBranchDefault: (projectId: string) => void; | ||
| setLastHostTarget: (target: V2WorkspaceCreateHostTarget) => void; | ||
| } | ||
|
|
||
| export const useV2WorkspaceCreateDefaultsStore = | ||
| create<V2WorkspaceCreateDefaultsState>()( | ||
| devtools( | ||
| persist( | ||
| (set) => ({ | ||
| lastProjectId: null, | ||
| baseBranchesByProjectId: {}, | ||
| lastHostTarget: null, | ||
|
|
||
| setLastProjectId: (projectId) => set({ lastProjectId: projectId }), | ||
|
|
||
| setBaseBranchDefault: (projectId, branchName, source) => { | ||
| const trimmed = branchName.trim(); | ||
| if (!trimmed) return; | ||
| set((state) => ({ | ||
| baseBranchesByProjectId: { | ||
| ...state.baseBranchesByProjectId, | ||
| [projectId]: { branchName: trimmed, source }, | ||
| }, | ||
| })); | ||
| }, | ||
|
|
||
| clearBaseBranchDefault: (projectId) => | ||
| set((state) => { | ||
| if (!(projectId in state.baseBranchesByProjectId)) return state; | ||
| const next = { ...state.baseBranchesByProjectId }; | ||
| delete next[projectId]; | ||
| return { baseBranchesByProjectId: next }; | ||
| }), | ||
|
|
||
| setLastHostTarget: (target) => set({ lastHostTarget: target }), | ||
| }), | ||
| { | ||
| name: "v2-workspace-create-defaults", | ||
| version: 1, | ||
| }, | ||
| ), | ||
| { name: "V2WorkspaceCreateDefaultsStore" }, | ||
| ), | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.