Skip to content

improve v2 terminal drop hover animation #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
Apr 26, 2026
Merged

improve v2 terminal drop hover animation #3769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .../v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { RendererContext } from "@superset/panes";
import { cn } from "@superset/ui/utils";
import { workspaceTrpc } from "@superset/workspace-client";
import "@xterm/xterm/css/xterm.css";
import {
Expand Down Expand Up @@ -377,7 +378,7 @@ export function TerminalPane({
return (
<div
role="application"
className="flex h-full w-full flex-col p-2"
className="relative flex h-full w-full flex-col p-2"
onDragEnter={handleDragEnter}
onDragOver={handleDragOver}
onDragLeave={handleDragLeave}
Expand All @@ -395,10 +396,13 @@ export function TerminalPane({
style={{ backgroundColor: appearance.background }}
/>
<ScrollToBottomButton terminal={terminal} />
{isDropActive && (
<div className="pointer-events-none absolute inset-0 rounded-sm border-2 border-primary/60 border-dashed bg-primary/10" />
)}
</div>
<div
className={cn(
"pointer-events-none absolute inset-0 bg-primary/10 transition-opacity duration-100",
isDropActive ? "opacity-75" : "opacity-0",
)}
/>
{connectionState === "closed" && (
<div className="flex items-center gap-2 border-t border-border px-3 py-1.5 text-xs text-muted-foreground">
<span>Disconnected</span>
Expand Down
Loading