Skip to content

fix(desktop): claim TERM_PROGRAM=kitty so TUIs parse Shift+Enter CSI-u #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 11 commits into from
Apr 23, 2026
+7 −3
Merged

fix(desktop): claim TERM_PROGRAM=kitty so TUIs parse Shift+Enter CSI-u #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
70bd191
fix(desktop): adopt Ghostty keyboard model in v2 terminal
Kitenite Apr 23, 2026
23d9024
fix(desktop): track kitty flags to gate Shift+Enter CSI-u injection
Kitenite Apr 23, 2026
7e650d6
chore(desktop): instrument v2 terminal keyboard path for diagnosis
Kitenite Apr 23, 2026
615e493
fix(desktop): match Shift+Enter CSI-u form to active kitty flags
Kitenite Apr 23, 2026
8eed80f
chore(desktop): log keyup too, in addition to keydown
Kitenite Apr 23, 2026
c4fb3bb
chore(desktop): disable Shift+Enter override to capture xterm raw output
Kitenite Apr 23, 2026
3ec25f0
fix(host-service): claim TERM_PROGRAM=kitty so TUIs parse our CSI-u
Kitenite Apr 23, 2026
804f18d
chore(desktop): remove diagnostic instrumentation and abandoned overr…
Kitenite Apr 23, 2026
642803b
experiment(desktop): narrow Mac Cmd bubble back to VS Code-style
Kitenite Apr 23, 2026
94ab847
experiment(desktop): revert all renderer changes, keep only TERM_PROG…
Kitenite Apr 23, 2026
d55786d
chore(host-service): trim TERM_PROGRAM comment to essentials
Kitenite Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/host-service/src/terminal/env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ describe("buildV2TerminalEnv", () => {
const env = buildV2TerminalEnv(baseParams);
expect(env).toMatchObject({
TERM: "xterm-256color",
TERM_PROGRAM: "Superset",
TERM_PROGRAM: "kitty",
TERM_PROGRAM_VERSION: "2.0.0",
COLORTERM: "truecolor",
PWD: "/tmp/workspace",
Expand All @@ -405,7 +405,7 @@ describe("buildV2TerminalEnv", () => {
SUPERSET_AGENT_HOOK_PORT: "51741",
SUPERSET_AGENT_HOOK_VERSION: "2",
});
expect(env.TERM_PROGRAM).toBe("Superset");
expect(env.TERM_PROGRAM).toBe("kitty");
expect(env.LANG).toContain("UTF-8");
});

Expand Down
6 changes: 5 additions & 1 deletion packages/host-service/src/terminal/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ export function buildV2TerminalEnv(
Object.assign(env, getShellBootstrapEnv({ shell, baseEnv, supersetHomeDir }));

env.TERM = "xterm-256color";
env.TERM_PROGRAM = "Superset";
// claude-code and similar chat TUIs only parse kitty CSI-u (e.g. Shift+Enter
// → \x1b[13;2u) when TERM_PROGRAM ∈ {ghostty, kitty, iTerm.app, WezTerm,
// WarpTerminal}. xterm.js already emits the right bytes — claim kitty so
// they're parsed instead of submitted as plain Enter.
env.TERM_PROGRAM = "kitty";
env.TERM_PROGRAM_VERSION = hostServiceVersion;
env.COLORTERM = "truecolor";
env.COLORFGBG = themeType === "light" ? "0;15" : "15;0";
Expand Down
Loading