Skip to content

fix(desktop): wire v2 sidebar project settings to settings route#3592

Merged
Kitenite merged 1 commit into
mainfrom
curse-calculator
Apr 20, 2026
Merged

fix(desktop): wire v2 sidebar project settings to settings route#3592
Kitenite merged 1 commit into
mainfrom
curse-calculator

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Apr 20, 2026

Summary

  • The v2 dashboard sidebar's project context-menu "Project Settings" item was showing a "coming soon" toast. Navigate to /settings/project/$projectId instead, matching v1's ProjectHeader.handleOpenSettings logic.

Test plan

  • Right-click a project in the v2 dashboard sidebar → click Project Settings → verify it navigates to the project settings page (general tab)

Summary by cubic

Clicking Project Settings in the v2 dashboard sidebar now opens the project settings page for the selected project. We navigate to /settings/project/$projectId using @tanstack/react-router, replacing the “coming soon” toast and matching v1 behavior.

Written for commit 1a0df5b. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed project settings access in the dashboard sidebar - users can now navigate to project settings directly.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a081b3d7-005d-45c8-acd0-8ca970003d3f

📥 Commits

Reviewing files that changed from the base of the PR and between b2278b1 and 1a0df5b.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarProjectSection/hooks/useDashboardSidebarProjectSectionActions/useDashboardSidebarProjectSectionActions.ts

📝 Walkthrough

Walkthrough

A single hook was modified to replace a "coming soon" toast notification with actual navigation. The handleOpenSettings function now directs users to the project settings page by navigating to /settings/project/$projectId instead of displaying a placeholder message.

Changes

Cohort / File(s) Summary
Navigation Implementation
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarProjectSection/hooks/useDashboardSidebarProjectSectionActions/useDashboardSidebarProjectSectionActions.ts
Added useNavigate import and replaced "coming soon" toast with navigation to project settings route, passing project.id as route parameter.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A settings button, once just a dream,
Now hops straight where it should be!
No more "soon" in a toast so bright,
Navigation works—what a delight! 🌟

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description includes a clear summary and test plan, but is missing several required template sections: Related Issues, Type of Change, Testing (formal section), Screenshots, and Additional Notes. Complete the template by adding Related Issues, selecting appropriate Type of Change checkbox(es), expanding the Testing section, and including any Additional Notes as needed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(desktop): wire v2 sidebar project settings to settings route' is specific and directly describes the main change—wiring the project settings menu item to the settings route.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch curse-calculator

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 20, 2026

Greptile Summary

This PR wires up the v2 dashboard sidebar's "Project Settings" context-menu action, replacing a placeholder toast.info("Project Settings coming soon") with a proper navigate call to /settings/project/$projectId. The implementation matches v1's ProjectHeader.handleOpenSettings exactly. The target route has an index-redirect component that automatically redirects to the /general sub-route.

Key changes:

  • handleOpenSettings now calls useNavigate() to navigate to the project settings page instead of showing a "coming soon" toast.
  • The navigation target (/settings/project/$projectId) is consistent with the v1 sidebar implementation and is handled by an existing <Navigate> redirect to /general.

Confidence Score: 5/5

Safe to merge — targeted one-function fix with no side effects.

The change is minimal and correct: it replaces a stub toast with navigation logic identical to v1, the target route exists and properly redirects to the general tab, and no imports or state are left dangling.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarProjectSection/hooks/useDashboardSidebarProjectSectionActions/useDashboardSidebarProjectSectionActions.ts Replaces the 'coming soon' toast in handleOpenSettings with a navigate call to /settings/project/$projectId, matching v1 ProjectHeader behavior exactly. The index route at that path correctly redirects to /general.

Sequence Diagram

sequenceDiagram
    actor User
    participant Sidebar as DashboardSidebar (v2)
    participant Hook as useDashboardSidebarProjectSectionActions
    participant Router as TanStack Router
    participant IndexRoute as /settings/project/$projectId/
    participant GeneralPage as /settings/project/$projectId/general

    User->>Sidebar: Right-click project → "Project Settings"
    Sidebar->>Hook: handleOpenSettings()
    Hook->>Router: navigate({ to: "/settings/project/$projectId", params: { projectId } })
    Router->>IndexRoute: Load index route
    IndexRoute->>GeneralPage: Navigate replace to /general
    GeneralPage-->>User: Renders ProjectSettings (general tab)
Loading

Reviews (1): Last reviewed commit: "fix(desktop): wire v2 sidebar project se..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Kitenite Kitenite merged commit 316d086 into main Apr 20, 2026
7 checks passed
@Kitenite Kitenite deleted the curse-calculator branch April 20, 2026 20:12
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Kitenite added a commit that referenced this pull request May 4, 2026
Add v2 project setup section (#3566, #3605, #3606, #3592, #3626, #3632),
scheduled agent runs (#3576), Opus 4.7 (#3579), v1 review comments in pane
(#3596), configurable v2 link-click (#3600), Copy Branch Name (#3635),
safer terminal preset defaults (#3546), and /pricing page (#3639). Expand
bug fixes with v2 git correctness, cross-fork PR misattribution, terminal
paste/Unicode/Shift+Enter, and security bumps.
Kitenite added a commit that referenced this pull request May 6, 2026
…-27) (#3792)

* docs: generate weekly changelog 2026-04-27

* docs: reframe weekly changelog around v2 public beta

Lead with v2 public beta + Settings → Experimental enable, restructure
around the v1→v2 migration story, sidebar overhaul, cross-workspace
terminals, and v2 chat. Pull in ~30 v2 PRs the bot missed and demote
non-v2 items (Hosts page, marketing menu) to a brief "Also this week".

* docs: pull in missed v2 features and bug fixes

Add v2 project setup section (#3566, #3605, #3606, #3592, #3626, #3632),
scheduled agent runs (#3576), Opus 4.7 (#3579), v1 review comments in pane
(#3596), configurable v2 link-click (#3600), Copy Branch Name (#3635),
safer terminal preset defaults (#3546), and /pricing page (#3639). Expand
bug fixes with v2 git correctness, cross-fork PR misattribution, terminal
paste/Unicode/Shift+Enter, and security bumps.

* docs(changelog): add v2 public beta hero screenshot

* docs(changelog): add Settings → Experimental screenshot, compress hero

pngquant compression: v2-public-beta.png 704KB → 166KB (76%),
v2-enable-flag.png 160KB → 36KB (78%). No visible quality loss.

* docs(changelog): tighten v2 launch prose, condense bullet groups

* docs(changelog): reframe cloud-first pillar as remote workspaces

* docs(changelog): cut parallel-agents and honest-state pillars, fold into sub-sections

* docs(changelog): tweak title and lead phrasing

* docs(changelog): rewrite v2 launch lede around Twitter narrative

Pull the launch story (physical limits, 3 ex-CTOs, cloud workspaces)
into the lede, restructure pillars around Remote workspaces, Reimagined
diff view, and Superset CLI, and add v2-remote-workspaces and
v2-changes-pane screenshots to back the new sections.

* docs(changelog): add CLI install snippet and docs link

* docs(changelog): cut narrative lede, match standard changelog tone

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kiet Ho <hoakiet98@gmail.com>
saddlepaddle pushed a commit that referenced this pull request May 6, 2026
…-27) (#3792)

* docs: generate weekly changelog 2026-04-27

* docs: reframe weekly changelog around v2 public beta

Lead with v2 public beta + Settings → Experimental enable, restructure
around the v1→v2 migration story, sidebar overhaul, cross-workspace
terminals, and v2 chat. Pull in ~30 v2 PRs the bot missed and demote
non-v2 items (Hosts page, marketing menu) to a brief "Also this week".

* docs: pull in missed v2 features and bug fixes

Add v2 project setup section (#3566, #3605, #3606, #3592, #3626, #3632),
scheduled agent runs (#3576), Opus 4.7 (#3579), v1 review comments in pane
(#3596), configurable v2 link-click (#3600), Copy Branch Name (#3635),
safer terminal preset defaults (#3546), and /pricing page (#3639). Expand
bug fixes with v2 git correctness, cross-fork PR misattribution, terminal
paste/Unicode/Shift+Enter, and security bumps.

* docs(changelog): add v2 public beta hero screenshot

* docs(changelog): add Settings → Experimental screenshot, compress hero

pngquant compression: v2-public-beta.png 704KB → 166KB (76%),
v2-enable-flag.png 160KB → 36KB (78%). No visible quality loss.

* docs(changelog): tighten v2 launch prose, condense bullet groups

* docs(changelog): reframe cloud-first pillar as remote workspaces

* docs(changelog): cut parallel-agents and honest-state pillars, fold into sub-sections

* docs(changelog): tweak title and lead phrasing

* docs(changelog): rewrite v2 launch lede around Twitter narrative

Pull the launch story (physical limits, 3 ex-CTOs, cloud workspaces)
into the lede, restructure pillars around Remote workspaces, Reimagined
diff view, and Superset CLI, and add v2-remote-workspaces and
v2-changes-pane screenshots to back the new sections.

* docs(changelog): add CLI install snippet and docs link

* docs(changelog): cut narrative lede, match standard changelog tone

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kiet Ho <hoakiet98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant