Skip to content

feat(desktop): v2 file editor — foundation, views, and stability pass #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 16 commits into from
Apr 17, 2026
Merged

feat(desktop): v2 file editor — foundation, views, and stability pass #3526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2965a78
docs(desktop): add v2 file editor audit + implementation plans
saddlepaddle Apr 13, 2026
bd4a5a8
feat(desktop): v2 file editor foundation — shared document store + re…
saddlepaddle Apr 16, 2026
31b5f7f
feat(desktop): v2 file editor state machine + chrome — pendingSave/sa…
saddlepaddle Apr 16, 2026
744b7b8
feat(desktop): v2 file editor views + toggle — MarkdownPreviewView, I…
saddlepaddle Apr 16, 2026
93cf059
feat(desktop): v2 file editor fs:events — orphan detection, rename tr…
saddlepaddle Apr 16, 2026
8a72129
feat(desktop): v2 file editor close-pane save guard — wire Save actio…
saddlepaddle Apr 16, 2026
2ceb0b2
chore(desktop): remove superseded v2 file editor code — old renderers…
saddlepaddle Apr 16, 2026
ae573a4
feat(desktop): move v2 file pane view toggle into the tab header via …
saddlepaddle Apr 16, 2026
d8d676f
feat(desktop): v2 file editor visual polish — Lucide fold chevrons/pl…
saddlepaddle Apr 17, 2026
fbfab76
refactor(desktop): organize v2 CodeEditor into folder-per-module + de…
saddlepaddle Apr 17, 2026
443096c
refactor(desktop): move resolveActivePaneView under registry/utils/
saddlepaddle Apr 17, 2026
655a64c
feat(desktop): v2 file editor stability pass — rename tracking, save …
saddlepaddle Apr 17, 2026
6e07fec
fix(desktop): v2 "Don't Save" now discards the dirty buffer
saddlepaddle Apr 17, 2026
8d59238
feat(desktop): v2 image + binary + large-file handling
saddlepaddle Apr 17, 2026
b7cd725
feat(desktop): make v2 markdown preview read-only
saddlepaddle Apr 17, 2026
227571c
fix(desktop): address PR feedback from coderabbit review
saddlepaddle Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .superset/lib/setup/steps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ step_start_electric() {

if ! docker run -d \
--name "$ELECTRIC_CONTAINER" \
--restart unless-stopped \
--restart on-failure:5 \
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: on-failure:5 weakens container persistence for a service started in one-time setup. After Docker/host restarts, Electric may stay down and break local dev until setup is rerun.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .superset/lib/setup/steps.sh, line 262:

<comment>`on-failure:5` weakens container persistence for a service started in one-time setup. After Docker/host restarts, Electric may stay down and break local dev until setup is rerun.</comment>

<file context>
@@ -259,7 +259,7 @@ step_start_electric() {
   if ! docker run -d \
       --name "$ELECTRIC_CONTAINER" \
-      --restart unless-stopped \
+      --restart on-failure:5 \
       $port_flag \
       -e DATABASE_URL="$DIRECT_URL" \
</file context>
Suggested change
--restart on-failure:5 \
--restart unless-stopped \
Fix with Cubic

$port_flag \
-e DATABASE_URL="$DIRECT_URL" \
-e ELECTRIC_SECRET="$ELECTRIC_SECRET" \
Expand Down
1 change: 1 addition & 0 deletions apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"@pierre/diffs": "1.1.3",
"@radix-ui/react-dialog": "^1.1.15",
"@radix-ui/react-label": "^2.1.8",
"@replit/codemirror-css-color-picker": "^6.3.0",
"@sentry/electron": "^7.7.0",
"@streamdown/mermaid": "1.0.2",
"@superset/auth": "workspace:*",
Expand Down
301 changes: 301 additions & 0 deletions apps/desktop/plans/20260412-file-editor-v2-feature-audit.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading