-
Notifications
You must be signed in to change notification settings - Fork 968
fix(desktop): use native clipboard for copy path in v2 sidebar #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a8ce290
fix(desktop): use native clipboard for copy path in v2 sidebar
Kitenite 2f53c30
feat(desktop): wire up Copy Path in v2 dashboard sidebar
Kitenite d017c84
feat(desktop): wire up Open in Finder in v2 dashboard sidebar
Kitenite 4405ddc
refactor(desktop): extract shared PathActionsMenuItems, wrap copy in …
Kitenite 5380421
refactor(desktop): hide Open in Finder & Copy Path for non-local work…
Kitenite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...omponents/WorkspaceFilesTreeItem/components/PathActionsMenuItems/PathActionsMenuItems.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { | ||
| ContextMenuItem, | ||
| ContextMenuSeparator, | ||
| } from "@superset/ui/context-menu"; | ||
| import { toast } from "@superset/ui/sonner"; | ||
| import { useCopyToClipboard } from "renderer/hooks/useCopyToClipboard"; | ||
| import { electronTrpcClient } from "renderer/lib/trpc-client"; | ||
|
|
||
| interface PathActionsMenuItemsProps { | ||
| absolutePath: string; | ||
| relativePath?: string; | ||
| } | ||
|
|
||
| export function PathActionsMenuItems({ | ||
| absolutePath, | ||
| relativePath, | ||
| }: PathActionsMenuItemsProps) { | ||
| const { copyToClipboard } = useCopyToClipboard(); | ||
|
|
||
| const handleCopy = async (path: string, successMessage: string) => { | ||
| try { | ||
| await copyToClipboard(path); | ||
| toast.success(successMessage); | ||
| } catch (error) { | ||
| toast.error( | ||
| `Failed to copy path: ${error instanceof Error ? error.message : "Unknown error"}`, | ||
| ); | ||
| } | ||
| }; | ||
|
|
||
| const handleRevealInFinder = async () => { | ||
| try { | ||
| await electronTrpcClient.external.openInFinder.mutate(absolutePath); | ||
| } catch (error) { | ||
| toast.error( | ||
| `Failed to reveal in Finder: ${error instanceof Error ? error.message : "Unknown error"}`, | ||
| ); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <ContextMenuItem onSelect={handleRevealInFinder}> | ||
| Reveal in Finder | ||
| </ContextMenuItem> | ||
| <ContextMenuSeparator /> | ||
| <ContextMenuItem onSelect={() => handleCopy(absolutePath, "Path copied")}> | ||
| Copy Path | ||
| </ContextMenuItem> | ||
| {relativePath && ( | ||
| <ContextMenuItem | ||
| onSelect={() => handleCopy(relativePath, "Relative path copied")} | ||
| > | ||
| Copy Relative Path | ||
| </ContextMenuItem> | ||
| )} | ||
| </> | ||
| ); | ||
| } |
1 change: 1 addition & 0 deletions
1
...nents/FilesTab/components/WorkspaceFilesTreeItem/components/PathActionsMenuItems/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { PathActionsMenuItems } from "./PathActionsMenuItems"; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.