fix(desktop): restore cmd+click for v1 terminal file links

[Kitenite]

Summary

• v1 terminal file-path links reverted to opening on plain click after Port link detection v2 to v1 #3382 ported v1 to the shared TerminalLinkManager. The old FilePathLinkProvider required cmd/ctrl; the shared LinkDetectorAdapter (also used by v2) activates on plain click.
• Gate onFileLinkClick behind metaKey/ctrlKey in v1's helpers.ts so v1 requires the modifier again without changing v2 behavior.
• Web URLs were already correctly gated in UrlLinkProvider; this fix aligns file-path links with that.

Test plan

• In v1 terminal, plain-click a file path in output — nothing happens.
• Cmd/Ctrl+click a file path — opens in file viewer / external editor per setting.
• Cmd/Ctrl+click a URL — still opens in browser.
• v2 terminal file-link click behavior unchanged.

---

Summary by cubic

Restore Cmd/Ctrl+click requirement for file-path links in the v1 terminal; plain clicks no longer open files. URL clicks and v2 terminal behavior are unchanged.

^{Written for commit 7c67db1. Summary will update on new commits.}

Summary by CodeRabbit

• Terminal
  • File links in the Terminal now require pressing a modifier key (Ctrl or Cmd) to open.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3c7baafb-ca64-4fe0-9a8f-d7b4f53b691d

📥 Commits

Reviewing files that changed from the base of the PR and between 47efa73 and 7c67db1.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts

---

📝 Walkthrough

Walkthrough

Added a modifier key requirement to terminal file link click handling. The onFileLinkClick handler now returns early unless the mouse event includes either metaKey or ctrlKey, preventing unintended file link activation from regular clicks.

Changes

Cohort / File(s)	Summary
Terminal Link Click Handler apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts	Added early return condition to onFileLinkClick that short-circuits processing unless event.metaKey or event.ctrlKey is active, requiring modifier key combinations to trigger file link navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A click without a key won't do,
Mod+Click's the rabbit's trick so true,
Links stay put till fingers dance,
With Ctrl or Cmd's commanding glance! 🖱️✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch garrulous-ricotta

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

[greptile-apps]

Greptile Summary

This PR fixes a regression introduced in #3382, where v1 terminal file-path links began opening on plain click after being ported to the shared TerminalLinkManager. The LinkDetectorAdapter (shared by both v1 and v2) activates links on any click, unlike the old FilePathLinkProvider which required Cmd/Ctrl. The fix adds a three-line metaKey/ctrlKey guard at the top of the v1 onFileLinkClick handler in helpers.ts, restoring the modifier-key requirement without touching v2 behavior.

• Adds if (!event.metaKey && !event.ctrlKey) { return; } guard to onFileLinkClick in helpers.ts (v1 terminal setup)
• Aligns v1 file-link behavior with UrlLinkProvider.handleActivation and the v2 TerminalPane.tsx handler, both of which already gate on the same modifier keys
• The WordLinkDetector path (bare filenames like AGENTS.md) also flows through onFileLinkClick, so it correctly inherits the modifier-key requirement as well
• v2 terminal behavior is unaffected — its own onFileLinkClick in TerminalPane.tsx already had the same guard independently

Confidence Score: 5/5

• Safe to merge — the fix is a minimal, targeted guard that correctly restores the intended v1 behavior without touching v2.
• The change is three lines, matches the established pattern in both v2 (TerminalPane.tsx) and UrlLinkProvider, and directly addresses the regression. The only note is a missing event.preventDefault() for consistency, but it is unlikely to cause a practical problem in the Electron xterm canvas context and does not affect correctness of the primary fix.
• No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts	Adds a metaKey/ctrlKey guard to onFileLinkClick; functionally correct and consistent with v2 and UrlLinkProvider, but is missing event.preventDefault() that both peer implementations call after the guard passes.

Sequence Diagram

sequenceDiagram
    participant User
    participant xterm
    participant LinkDetectorAdapter
    participant onFileLinkClick as onFileLinkClick (helpers.ts)
    participant v1Handler as v1 file-open action

    User->>xterm: plain click on file path
    xterm->>LinkDetectorAdapter: activate(event, detectedLink)
    LinkDetectorAdapter->>onFileLinkClick: onFileLinkClick(event, link)
    onFileLinkClick->>onFileLinkClick: "metaKey || ctrlKey?"
    Note over onFileLinkClick: NO → early return (fix)
    onFileLinkClick-->>LinkDetectorAdapter: (no-op)

    User->>xterm: Cmd/Ctrl+click on file path
    xterm->>LinkDetectorAdapter: activate(event, detectedLink)
    LinkDetectorAdapter->>onFileLinkClick: onFileLinkClick(event, link)
    onFileLinkClick->>onFileLinkClick: "metaKey || ctrlKey?"
    Note over onFileLinkClick: YES → proceed
    onFileLinkClick->>v1Handler: openFileInEditor.mutate(...)
    v1Handler-->>User: file opens in editor

Loading

Comments Outside Diff (1)

1. apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts, line 171-178 (link)

   Missing event.preventDefault() after guard

   Both peer implementations call event.preventDefault() after the modifier-key guard passes, before performing the action:

   • UrlLinkProvider.handleActivation (line 350 of url-link-provider.ts): calls event.preventDefault() before this.onOpen(...).
   • v2 TerminalPane.tsx (line 146): calls _event.preventDefault() before openFileInEditor.mutate(...).

   Without it, Cmd+Click (macOS) or Ctrl+Click (Windows) can still bubble through xterm's event handling and trigger Electron/Chromium defaults (e.g., Cmd+Click on a canvas in Electron may be interpreted by the OS or the webContents in unexpected ways). Aligning with the pattern used by both sibling implementations would be safer:

_{Reviews (1): Last reviewed commit: "fix(desktop): restore cmd+click requirem..." | Re-trigger Greptile}