Skip to content

fix(desktop): forward unregistered ctrl/meta chords to v1 terminal PTY #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 1 commit into from
Apr 12, 2026
+8 −4
Merged

fix(desktop): forward unregistered ctrl/meta chords to v1 terminal PTY #3390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...enderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import { Unicode11Addon } from "@xterm/addon-unicode11";
import { WebglAddon } from "@xterm/addon-webgl";
import type { ITheme } from "@xterm/xterm";
import { Terminal as XTerm } from "@xterm/xterm";
import { getBinding, isTerminalReservedEvent } from "renderer/hotkeys";
import {
getBinding,
isTerminalReservedEvent,
resolveHotkeyFromEvent,
} from "renderer/hotkeys";
import type { DetectedLink } from "renderer/lib/terminal/links";
import { TerminalLinkManager } from "renderer/lib/terminal/terminal-link-manager";
import { electronTrpcClient as trpcClient } from "renderer/lib/trpc-client";
Expand Down Expand Up @@ -592,9 +596,9 @@ export function setupKeyboardHandler(
return false;
}

// Any other ctrl/meta combo → let it bubble to document for react-hotkeys-hook
if (event.type === "keydown" && (event.metaKey || event.ctrlKey))
return false;
// Only bubble chords registered as app hotkeys; everything else reaches the PTY.
// Mirrors v2 terminal-runtime.ts:21 (VSCode terminalInstance pattern).
if (resolveHotkeyFromEvent(event) !== null) return false;

return true;
};
Expand Down
Loading