refactor(desktop): replace lucide-react with react-icons/lu by Kitenite · Pull Request #314 · superset-sh/superset

Kitenite · 2025-12-10T21:22:28Z

Summary

Replace all lucide-react icon imports with react-icons/lu equivalents in the desktop app
Remove lucide-react dependency from apps/desktop/package.json
Update ActionCard component to use IconType from react-icons instead of LucideIcon

Test plan

Verify typecheck passes (bun run typecheck --filter=@superset/desktop)
Verify all icons render correctly in the desktop app
Verify no visual regressions in affected components

🤖 Generated with Claude Code

Summary by CodeRabbit

Refactor
- Migrated the app’s icon library from one provider to another, updating icons across the UI. No functional changes; visuals and behavior preserved.
Chores
- Removed the old icon library dependency from the desktop app package.
Minor
- Added a new "none" status option for check summaries to improve status display handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Migrate all lucide-react icon imports to use react-icons/lu equivalents to consolidate on a single icon library (react-icons). This reduces bundle size by removing the lucide-react dependency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2025-12-10T21:22:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
website	Ready	Preview	Comment	Dec 10, 2025 9:27pm

coderabbitai · 2025-12-10T21:22:38Z

Walkthrough

The pull request removes the lucide-react dependency and replaces lucide-react icon imports/usages with react-icons/lu equivalents across the desktop app, plus a type change from LucideIcon to IconType in one component.

Changes

Cohort / File(s)	Change Summary
Dependency Removal `apps/desktop/package.json`	Removed `lucide-react` from `dependencies`.
StartView `apps/desktop/src/renderer/screens/main/components/StartView/ActionCard.tsx`, `apps/desktop/src/renderer/screens/main/components/StartView/index.tsx`	Swapped lucide-react types/imports/usages to react-icons: changed `LucideIcon` → `IconType` and replaced icons (e.g., `ChevronUp` → `LuChevronUp`, `FolderOpen` → `LuFolderOpen`, `FolderGit` → `LuFolderGit`, `X` → `LuX`).
Workspace Hover Card & Checks `apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/WorkspaceHoverCard.tsx`, `.../ChecksList/ChecksList.tsx`, `.../CheckItemRow/CheckItemRow.tsx`, `.../ChecksSummary/ChecksSummary.tsx`	Replaced lucide-react icon imports/usages with `react-icons/lu` equivalents (e.g., `ExternalLink`→`LuExternalLink`, `LoaderCircle`→`LuLoaderCircle`, `TriangleAlert`→`LuTriangleAlert`, `ChevronDown`→`LuChevronDown`, `Check`→`LuCheck`, `X`→`LuX`). Also added `"none"` to `ChecksSummaryProps` status union.
Tab Content Context Menu `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabContentContextMenu.tsx`	Replaced lucide-react icons with `react-icons/lu` equivalents (e.g., `Rows2`→`LuRows2`, `Columns2`→`LuColumns2`, `Eraser`→`LuEraser`, `MoveRight`→`LuMoveRight`, `Plus`→`LuPlus`, `X`→`LuX`).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Verify icon name mappings and imports across the listed files.
Confirm IconType change in ActionCard.tsx is type-compatible.
Check ChecksSummaryProps addition of "none" is intended and handled.

Possibly related PRs

use ui state #103 — Same change set: remove lucide-react and migrate icon imports to react-icons.
Add workspace hover cards with GitHub PR status #233 — Modifies WorkspaceHoverCard and checks-related components that were updated here.
feat(desktop): add icons to terminal pane context menu #251 — Previously changed TabContentContextMenu icon usage now updated again in this PR.

Poem

🐰 A hop, a swap, the icons change with cheer,
Lucide waves, react-icons appear —
Chevrons, folders, tiny Xs take flight,
Eight files tidied in the soft moonlight. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description check	❓ Inconclusive	The description is partially complete but missing several required template sections including Related Issues, Type of Change checkbox, and Testing details beyond an unchecked test plan.	Complete the description template by checking the 'Refactor' checkbox under Type of Change and providing more detail on testing steps and verification results.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title accurately summarizes the main change: replacing lucide-react with react-icons/lu in the desktop app, which aligns with all file changes shown in the changeset.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch replace-lucide-with-react-icons

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f2005b and a6c7158.

📒 Files selected for processing (6)

apps/desktop/src/renderer/screens/main/components/StartView/index.tsx (4 hunks)
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/WorkspaceHoverCard.tsx (3 hunks)
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksList/ChecksList.tsx (2 hunks)
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksList/components/CheckItemRow/CheckItemRow.tsx (1 hunks)
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx (2 hunks)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabContentContextMenu.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

apps/desktop/src/renderer/screens/main/components/StartView/index.tsx
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksList/components/CheckItemRow/CheckItemRow.tsx
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/WorkspaceHoverCard.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabContentContextMenu.tsx
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksList/ChecksList.tsx

🧰 Additional context used

📓 Path-based instructions (5)

apps/desktop/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc

Files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: Please use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary

Files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Maintain type safety and avoid using any unless absolutely necessary in TypeScript code

Files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

**/components/**/[A-Z]*.tsx

📄 CodeRabbit inference engine (AGENTS.md)

Use one folder per component with structure ComponentName/ComponentName.tsx + index.ts barrel export

Files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

apps/desktop/src/renderer/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Never import Node.js modules in renderer process or shared code - only in src/main/

Files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

🧠 Learnings (1)

📚 Learning: 2025-12-08T23:32:32.232Z

Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T23:32:32.232Z
Learning: Applies to src/components/{ui,ai-elements,react-flow}/**/*.tsx : Use kebab-case single files for shadcn/ui components in src/components/ui/, src/components/ai-elements, and src/components/react-flow/

Applied to files:

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build

🔇 Additional comments (1)

apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/WorkspaceHoverCard/components/ChecksSummary/ChecksSummary.tsx (1)

2-29: Icon migration and status handling in ChecksSummary look correct

The lucide → react-icons/lu swap is consistent and preserves semantics: LuCheck for success, LuX for failure, and LuLoaderCircle with animate-spin for pending. The "none" status is safely short‑circuited before indexing into config, so both runtime behavior and typing remain sound, and renderer‑side imports avoid Node modules.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-10T21:29:52Z

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

⚠️ Neon database branch

Thank you for your contribution! 🎉

lint

a6c7158

vercel Bot deployed to Preview December 10, 2025 21:27 View deployment

Kitenite merged commit dff5957 into main Dec 10, 2025
6 of 8 checks passed

Kitenite deleted the replace-lucide-with-react-icons branch December 10, 2025 21:29

This was referenced Dec 11, 2025

Changes tab UI beautification #317

Merged

implement more font and xterm rendering improvements #324

Merged

coderabbitai Bot mentioned this pull request Jan 6, 2026

feature (desktop): sidebar style and close functionality #618

Merged

5 tasks

coderabbitai Bot mentioned this pull request Feb 2, 2026

feat(desktop): improve file tree icons with VS Code style icons #1145

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(desktop): replace lucide-react with react-icons/lu#314

refactor(desktop): replace lucide-react with react-icons/lu#314
Kitenite merged 2 commits intomainfrom
replace-lucide-with-react-icons

Kitenite commented Dec 10, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Kitenite commented Dec 10, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

vercel Bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2025

🧹 Preview Cleanup Complete

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Kitenite commented Dec 10, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Dec 10, 2025 •

edited

Loading

coderabbitai Bot commented Dec 10, 2025 •

edited

Loading