Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@superset/desktop",
"productName": "Superset",
"description": "The last developer tool you'll ever need",
"version": "1.4.6",
"version": "1.4.7",
"main": "./dist/main/index.js",
"resources": "src/resources",
"repository": {
Expand Down
29 changes: 17 additions & 12 deletions apps/desktop/src/renderer/stores/tabs/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -756,17 +756,18 @@ export const useTabsStore = create<TabsStore>()(

const tabPaneIds = extractPaneIdsFromLayout(activeTab.layout);
const reuseExisting = options.reuseExisting ?? "workspace";
const existingFileViewerPane = reuseExisting !== "none"
? findReusableFileViewerPane({
workspaceId,
activeTabId: activeTab.id,
tabs: state.tabs,
panes: state.panes,
tabHistoryStacks: state.tabHistoryStacks,
reuseExisting,
options,
})
: null;
const existingFileViewerPane =
reuseExisting !== "none"
? findReusableFileViewerPane({
workspaceId,
activeTabId: activeTab.id,
tabs: state.tabs,
panes: state.panes,
tabHistoryStacks: state.tabHistoryStacks,
reuseExisting,
options,
})
: null;

if (existingFileViewerPane) {
const nextPane = applyFileViewerOpenOptionsToPane(
Expand Down Expand Up @@ -826,7 +827,11 @@ export const useTabsStore = create<TabsStore>()(

// If we found an unpinned (preview) file-viewer pane, reuse it
// (skip reuse when explicitly requesting a new tab, e.g. cmd+click)
if (fileViewerPanes.length > 0 && !options.openInNewTab && reuseExisting !== "none") {
if (
fileViewerPanes.length > 0 &&
!options.openInNewTab &&
reuseExisting !== "none"
) {
const paneToReuse = fileViewerPanes[0];
const existingFileViewer = paneToReuse.fileViewer;
if (!existingFileViewer) {
Expand Down
Loading