Skip to content

fix(desktop): prevent duplicate panes when file-open mode is new-tab #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 1 commit into from
Apr 3, 2026
Merged

fix(desktop): prevent duplicate panes when file-open mode is new-tab #3093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions apps/desktop/src/renderer/stores/tabs/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,9 +756,7 @@ export const useTabsStore = create<TabsStore>()(

const tabPaneIds = extractPaneIdsFromLayout(activeTab.layout);
const reuseExisting = options.reuseExisting ?? "workspace";
const canReuseExistingPane =
!options.openInNewTab && reuseExisting !== "none";
const existingFileViewerPane = canReuseExistingPane
const existingFileViewerPane = reuseExisting !== "none"
? findReusableFileViewerPane({
workspaceId,
activeTabId: activeTab.id,
Expand Down Expand Up @@ -828,7 +826,7 @@ export const useTabsStore = create<TabsStore>()(

// If we found an unpinned (preview) file-viewer pane, reuse it
// (skip reuse when explicitly requesting a new tab, e.g. cmd+click)
if (fileViewerPanes.length > 0 && canReuseExistingPane) {
if (fileViewerPanes.length > 0 && !options.openInNewTab && reuseExisting !== "none") {
const paneToReuse = fileViewerPanes[0];
const existingFileViewer = paneToReuse.fileViewer;
if (!existingFileViewer) {
Expand Down
Loading