Skip to content

fix(desktop): match dropdown trigger color to run button state #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 2 commits into from
Mar 30, 2026
Merged

fix(desktop): match dropdown trigger color to run button state #3009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e90fc
fix(desktop): match dropdown trigger color to run button state
Kitenite Mar 30, 2026
4718564
Lint
Kitenite Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ticated/_dashboard/components/TopBar/components/WorkspaceRunButton/WorkspaceRunButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ export const WorkspaceRunButton = memo(function WorkspaceRunButton({
"focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring",
"active:scale-[0.98]",
isPending && "opacity-50 pointer-events-none",
isRunning
? "text-emerald-300 border-emerald-500/25 bg-emerald-500/10 hover:bg-emerald-500/20"
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: In the running state, hover will still apply hover:text-foreground from the base classes, so the chevron text turns default on hover instead of staying emerald. Add a running-state hover text override to keep the colors consistent with the left button.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/WorkspaceRunButton/WorkspaceRunButton.tsx, line 146:

<comment>In the running state, hover will still apply `hover:text-foreground` from the base classes, so the chevron text turns default on hover instead of staying emerald. Add a running-state hover text override to keep the colors consistent with the left button.</comment>

<file context>
@@ -142,6 +142,10 @@ export const WorkspaceRunButton = memo(function WorkspaceRunButton({
 							"active:scale-[0.98]",
 							isPending && "opacity-50 pointer-events-none",
+							isRunning
+								? "text-emerald-300 border-emerald-500/25 bg-emerald-500/10 hover:bg-emerald-500/20"
+								: !hasRunCommand &&
+									"text-muted-foreground/80 border-border/40 bg-secondary/40",
</file context>
Suggested change
? "text-emerald-300 border-emerald-500/25 bg-emerald-500/10 hover:bg-emerald-500/20"
? "text-emerald-300 border-emerald-500/25 bg-emerald-500/10 hover:bg-emerald-500/20 hover:text-emerald-300"
Fix with Cubic

: !hasRunCommand &&
"text-muted-foreground/80 border-border/40 bg-secondary/40",
)}
>
<HiChevronDown className="size-3.5" />
Expand Down
Loading