[codex] Harden desktop image data URL handling#3003
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughCentralizes image MIME type and extension handling by introducing shared utility functions ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/desktop/src/main/lib/project-icons.ts">
<violation number="1" location="apps/desktop/src/main/lib/project-icons.ts:116">
P2: Reject empty base64 payloads before saving; the new parser path allows `data:image/...;base64,` and writes a 0-byte icon file.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| const ext = match[1] === "jpeg" ? "jpg" : match[1]; | ||
| const buffer = Buffer.from(match[2], "base64"); | ||
| const { buffer, ext } = parseProjectIconDataUrl(dataUrl); |
Contributor
There was a problem hiding this comment.
P2: Reject empty base64 payloads before saving; the new parser path allows data:image/...;base64, and writes a 0-byte icon file.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop/src/main/lib/project-icons.ts, line 116:
<comment>Reject empty base64 payloads before saving; the new parser path allows `data:image/...;base64,` and writes a 0-byte icon file.</comment>
<file context>
@@ -89,14 +113,7 @@ export async function saveProjectIconFromDataUrl({
-
- const ext = match[1] === "jpeg" ? "jpg" : match[1];
- const buffer = Buffer.from(match[2], "base64");
+ const { buffer, ext } = parseProjectIconDataUrl(dataUrl);
if (buffer.length > MAX_ICON_SIZE) {
</file context>
Suggested change
| const { buffer, ext } = parseProjectIconDataUrl(dataUrl); | |
| const { buffer, ext } = parseProjectIconDataUrl(dataUrl); | |
| if (buffer.length === 0) { | |
| throw new Error("Invalid data URL format"); | |
| } |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
siarhei-belavus
pushed a commit
to siarhei-belavus/localset
that referenced
this pull request
Mar 30, 2026
(cherry picked from commit 5839970)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.icouploads with surfaced mutation errorsWhy
Project icon uploads were relying on a narrow regex in the main-process save path. That broke valid browser-generated data URLs for formats like ICO variants and SVG data URLs with extra MIME parameters. The same MIME parsing pattern also existed in other desktop upload flows.
Impact
image/x-iconandimage/vnd.microsoft.iconValidation
bun test apps/desktop/src/shared/file-types.test.ts apps/desktop/src/main/lib/project-icons.test.tsbunx biome check --write 'apps/desktop/src/main/lib/project-icons.ts' 'apps/desktop/src/main/lib/project-icons.test.ts' 'apps/desktop/src/shared/file-types.ts' 'apps/desktop/src/shared/file-types.test.ts' 'apps/desktop/src/lib/trpc/routers/window.ts' 'apps/desktop/src/renderer/routes/_authenticated/settings/account/components/AccountSettings/AccountSettings.tsx' 'apps/desktop/src/renderer/routes/_authenticated/settings/organization/components/OrganizationSettings/OrganizationSettings.tsx' 'apps/desktop/src/renderer/routes/_authenticated/settings/project/$projectId/components/ProjectSettings/ProjectSettings.tsx'bunx tsc -p apps/desktop/tsconfig.json --noEmit --ignoreDeprecations 6.0currently fails on an existing unrelated error inapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx(62,4): error TS2871: This expression is always nullish.Summary by cubic
Centralized and hardened desktop image data URL parsing/normalization to fix project icon uploads and make desktop image uploads consistent. Icons now accept ICO variants and SVG data URLs with extra parameters, and errors surface in the UI.
Bug Fixes
image/x-iconandimage/vnd.microsoft.icon; JPEG normalized to.jpg; SVG with extra params parsed correctly..icoandimage/vnd.microsoft.icon; show toast on mutation errors.Refactors
shared/file-typeshelpers:getImageMimeType,getImageExtensionFromMimeType,parseBase64DataUrl; reused across project, account, and org uploads.parseProjectIconDataUrlwith a PNG/JPEG/SVG/ICO allowlist.shared/file-typesand project icon parsing.Written for commit 83baf82. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes