[codex] restore Codex loading state via native hooks

[Kitenite]

Summary

Restore the Codex pane running/loading indicator by switching Superset to Codex's supported hook path, enabling the upstream codex_hooks feature in the default Codex launch command, and migrating already-saved Codex terminal presets that still contain the stale pre-update command.

What Changed

• add UserPromptSubmit to the managed ~/.codex/hooks.json merge so Codex emits a supported start signal
• keep the wrapper/session-log watcher only as compatibility support for older Codex builds
• enable codex_hooks in Superset's default Codex terminal preset command
• migrate stored terminal presets whose Codex command still matches the legacy pre-hook command
• update shared, desktop, and settings-router tests that assert the default Codex command, hook setup, and preset normalization behavior

Root Cause

There were three layers to the regression after the upstream Codex update on March 27-28, 2026:

1. Superset was relying on internal Codex TUI session-log behavior for Start events, and upstream openai/codex changed that surface.
2. Superset's default Codex command still launched without --enable codex_hooks, so Codex never loaded hooks.json and no running-state start event could fire.
3. Existing users kept already-initialized terminal presets, so even after fixing the builtin default, saved Codex presets could still keep launching the stale command.

Impact

Codex panes should enter the running/working state again when a prompt is submitted on current Codex builds, including for existing saved Codex terminal presets once the preset normalization path runs.

Validation

• bun test packages/shared/src/agent-command.test.ts
• bun test apps/desktop/src/shared/utils/agent-launch-request.test.ts
• bun test apps/desktop/src/lib/trpc/routers/settings/preset-execution-mode.test.ts
• bun test apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts
• bun test apps/desktop/src/main/lib/notifications/server.test.ts
• bunx biome check apps/desktop/src/lib/trpc/routers/settings/preset-execution-mode.ts apps/desktop/src/lib/trpc/routers/settings/preset-execution-mode.test.ts packages/shared/src/agent-command.ts packages/shared/src/agent-command.test.ts apps/desktop/src/shared/utils/agent-launch-request.test.ts apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Fixed a configuration issue where the Codex hooks flag was missing from wrapper initialization, affecting notification delivery and hook activation.

• Tests

  • Added test coverage for argument forwarding and hook enablement to verify the wrapper correctly invokes the process with proper configuration.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f674c43-5006-42db-bd12-1eaa3539abf6

📥 Commits

Reviewing files that changed from the base of the PR and between bd61cc1 and 807632f.

📒 Files selected for processing (2)

• apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts
• apps/desktop/src/main/lib/agent-setup/templates/codex-wrapper-exec.template.sh

---

📝 Walkthrough

Walkthrough

The Codex wrapper initialization now includes the --enable codex_hooks flag when invoking the real Codex binary. The test file has been updated to validate this new flag is correctly passed through the wrapper to ensure the notification mechanism functions as expected.

Changes

Cohort / File(s)	Summary
Codex Wrapper Template apps/desktop/src/main/lib/agent-setup/templates/codex-wrapper-exec.template.sh	Added --enable codex_hooks flag to the Codex binary invocation, placed before the existing notification config parameter.
Wrapper Tests apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts	Updated existing Codex wrapper assertion to expect --enable codex_hooks flag and added new test case validating the flag is forwarded correctly through manual wrapper execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A flag to enable, a hook to adhere,
The Codex now dances with notifications clear,
Through wrappers and tests, the new flag takes flight,
With --enable codex_hooks, everything's right! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch debug-codex-loading-state-issue

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ✅ Neon database branch
• ✅ Electric Fly.io app

Thank you for your contribution! 🎉

[cubic-dev-ai]

No issues found across 2 files