Skip to content

fix(desktop): remove terminal backpressure warning #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 5 commits into from
Mar 30, 2026
+0 −5
Merged

fix(desktop): remove terminal backpressure warning #2996

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d98affb
fix(desktop): skip writes to backpressured terminal sockets and rate-…
Kitenite Mar 29, 2026
69ed33a
fix(desktop): preserve terminal lifecycle events under backpressure
Kitenite Mar 30, 2026
bfeaa39
fix(desktop): preserve terminal output under backpressure
Kitenite Mar 30, 2026
84e3963
test(desktop): trim terminal host session coverage
Kitenite Mar 30, 2026
a4617b3
fix(desktop): remove terminal backpressure warning
Kitenite Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/desktop/src/main/terminal-host/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,11 +1067,6 @@ export class Session {
try {
const canWrite = socket.write(message);
if (!canWrite) {
// Socket buffer full - data will be queued but may cause memory pressure
// In production, could track this and pause PTY output temporarily
console.warn(
`[Session ${this.sessionId}] Client socket buffer full, output may be delayed`,
);
this.handleClientBackpressure(socket);
}
} catch {
Expand Down
Loading