feat(desktop): UI + new notification sounds by Kitenite · Pull Request #298 · superset-sh/superset

Kitenite · 2025-12-09T17:54:26Z

Summary

Add two new notification sound options: arcade.mp3 and ping.mp3
Switch default notification sound from notification.mp3 to arcade.mp3

Test plan

Trigger a notification (agent complete or permission request) and verify arcade.mp3 plays
Verify sounds are bundled correctly in production build

🤖 Generated with Claude Code

Summary by CodeRabbit

Style
- Refined spacing and padding across workspace panes and inner content for tighter visual alignment
- Adjusted tab button spacing to improve layout balance
- Updated mosaic/tab background color to match design refinements
Chores
- Replaced the default notification sound asset used in development and production environments

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Add two new notification sound options and switch default to arcade.mp3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2025-12-09T17:54:31Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
website	Ready	Preview	Comment	Dec 9, 2025 6:54pm

coderabbitai · 2025-12-09T17:54:42Z

Walkthrough

Updates the desktop notification sound asset reference and makes small UI spacing and theme color adjustments in workspace-related renderer files and a CSS theme file.

Changes

Cohort / File(s)	Change Summary
Notification audio asset `apps/desktop/src/main/lib/notification-sound.ts`	Swapped notification audio filename from `notification.mp3` to `arcade.mp3` for both dev and prod paths returned by `getNotificationSoundPath()`.
UI layout and spacing adjustments `apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx`, `apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx`	Adjusted spacing classes: `TabsView` button group changed `mt-1` → `mb-1`; reduced padding by changing `p-2`/`p-1.5` classes to smaller/removed padding on WorkspaceView inner wrappers.
Mosaic theme styling `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/mosaic-theme.css`	Changed `.mosaic-container` background from `var(--background)` to `var(--color-tertiary)`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Check that arcade.mp3 is present in the shipped dev/prod asset paths and packaging.
Verify the --color-tertiary token is defined where themes are provided (CSS variable consistency).
Quick visual review of WorkspaceView and TabsView to confirm spacing behaves as intended across breakpoints.

Possibly related PRs

feat(desktop): add custom notification sound #296 — Edits the same notification-sound.ts logic/assets; likely directly related.
ui sanding #137 — Introduced/relates to the --color-tertiary token used by the mosaic theme change.
fix(desktop): more consistent layout #287 — Overlaps UI/layout files (mosaic-theme.css, WorkspaceView) with similar styling adjustments.

Poem

🐇 I heard an arcade chime so clear,
Padding shrank — the panels near,
Tertiary skies now softly glow,
Buttons settle, margins low.
A tiny rabbit cheers the show! 🎶

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description check	❓ Inconclusive	The PR description is incomplete. While it mentions the summary and test plan, it lacks the structured sections required by the template (Related Issues, Type of Change, Screenshots).	Fill out the missing template sections: add Related Issues section with any linked issues, explicitly mark the Type of Change checkboxes (should be 'New feature'), and note if screenshots are applicable.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat(desktop): add new notification sounds' accurately reflects the main change of adding new notification sound options and changing the default sound.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch standard-boar-f388c8

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0dc8d8 and d0dd7ea.

📒 Files selected for processing (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-09T17:54:57Z

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

✅ Neon database branch

Thank you for your contribution! 🎉

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f89c95 and a0dc8d8.

⛔ Files ignored due to path filters (2)

apps/desktop/src/resources/sounds/arcade.mp3 is excluded by !**/*.mp3
apps/desktop/src/resources/sounds/ping.mp3 is excluded by !**/*.mp3

📒 Files selected for processing (4)

apps/desktop/src/main/lib/notification-sound.ts (1 hunks)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/mosaic-theme.css (1 hunks)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx (1 hunks)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

apps/desktop/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx
apps/desktop/src/main/lib/notification-sound.ts

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: Please use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx
apps/desktop/src/main/lib/notification-sound.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Maintain type safety and avoid using any unless absolutely necessary in TypeScript code

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx
apps/desktop/src/main/lib/notification-sound.ts

apps/desktop/src/renderer/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Never import Node.js modules in renderer process or shared code - only in src/main/

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx

🧠 Learnings (2)

📚 Learning: 2025-12-08T23:32:32.232Z

Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T23:32:32.232Z
Learning: Applies to apps/desktop/src/main/lib/*{workspace,worktree}-*.ts : Use git worktree-based workspace management in the desktop app through workspace-manager.ts and worktree-manager.ts

Applied to files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx

📚 Learning: 2025-12-08T23:32:32.232Z

Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-08T23:32:32.232Z
Learning: Applies to src/components/{ui,ai-elements,react-flow}/**/*.tsx : Use kebab-case single files for shadcn/ui components in src/components/ui/, src/components/ai-elements, and src/components/react-flow/

Applied to files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx

🧬 Code graph analysis (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx (1)

packages/ui/src/components/button-group.tsx (1)

ButtonGroup (17-17)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build

🔇 Additional comments (3)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/mosaic-theme.css (1)

2-2: LGTM: Background color variable updated.

The background color change from var(--background) to var(--color-tertiary) is syntactically correct. However, note that this styling change appears unrelated to the "add new notification sounds" feature mentioned in the PR title.

apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx (1)

132-132: LGTM: Spacing adjustment.

The margin class change from mt-1 to mb-1 is a minor spacing refinement. However, this UI layout change appears unrelated to the "add new notification sounds" feature mentioned in the PR title.

apps/desktop/src/renderer/screens/main/components/WorkspaceView/index.tsx (1)

129-129: LGTM: Inner container padding removed.

The removal of p-1.5 padding is a minor layout refinement. However, this change appears unrelated to the "add new notification sounds" feature mentioned in the PR title.

Kitenite and others added 4 commits December 9, 2025 09:28

slight styling

5bc4056

update mosaic padding

e82655a

clean up

deed8ed

feat(desktop): add new notification sounds (arcade, ping)

a0dc8d8

Add two new notification sound options and switch default to arcade.mp3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai Bot reviewed Dec 9, 2025

View reviewed changes

Comment thread apps/desktop/src/main/lib/notification-sound.ts

save

d0dd7ea

vercel Bot deployed to Preview December 9, 2025 18:54 View deployment

Kitenite changed the title ~~feat(desktop): add new notification sounds~~ feat(desktop): UI + new notification sounds Dec 9, 2025

Kitenite merged commit ae57b6d into main Dec 9, 2025
8 checks passed

Kitenite deleted the standard-boar-f388c8 branch December 9, 2025 19:11

This was referenced Dec 11, 2025

feat(desktop): improve ringtone settings with duration display and bug fixes #318

Merged

fix (desktop): add default ringtone and rename some to be more pc #325

Merged

coderabbitai Bot mentioned this pull request Jan 29, 2026

feat (desktop): toggle for notifications #1045

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(desktop): UI + new notification sounds#298

feat(desktop): UI + new notification sounds#298
Kitenite merged 5 commits intomainfrom
standard-boar-f388c8

Kitenite commented Dec 9, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Kitenite commented Dec 9, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

vercel Bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions Bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧹 Preview Cleanup Complete

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Kitenite commented Dec 9, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Dec 9, 2025 •

edited

Loading

coderabbitai Bot commented Dec 9, 2025 •

edited

Loading

github-actions Bot commented Dec 9, 2025 •

edited

Loading