Skip to content

chore: remove remaining Outlit integration#2705

Merged
Kitenite merged 2 commits into
superset-sh:mainfrom
Kitenite:kitenite/check-outlit-key
Mar 21, 2026
Merged

chore: remove remaining Outlit integration#2705
Kitenite merged 2 commits into
superset-sh:mainfrom
Kitenite:kitenite/check-outlit-key

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Mar 21, 2026

Summary

  • remove Outlit providers and env validation from web, marketing, and docs
  • remove the remaining Outlit dependency and marketing tracking bridge
  • remove NEXT_PUBLIC_OUTLIT_KEY from env templates and CI/deploy workflow wiring

Testing

  • bun turbo run typecheck --filter=@superset/web --filter=@superset/marketing --filter=@superset/docs
  • bunx @biomejs/biome@2.4.2 check --write .env.example .github/workflows/ci.yml .github/workflows/build-desktop.yml .github/workflows/deploy-preview.yml .github/workflows/deploy-production.yml apps/docs/package.json apps/docs/src/app/layout.tsx apps/docs/src/env.ts apps/marketing/package.json apps/marketing/src/app/providers.tsx apps/marketing/src/components/CookieConsent/CookieConsent.tsx apps/marketing/src/env.ts apps/marketing/src/lib/analytics/index.ts apps/web/package.json apps/web/src/app/providers.tsx apps/web/src/env.ts

Summary by cubic

Removed all remaining Outlit analytics from web, marketing, and docs, and removed NEXT_PUBLIC_OUTLIT_KEY from CI and deploy workflows. PostHog is now the only analytics provider.

  • Refactors

    • Removed Outlit providers/components and env wiring across apps/web, apps/marketing, apps/docs, and CI/deploy workflows (including .env.example).
    • Simplified marketing analytics and cookie consent to rely only on PostHog; removed Outlit-specific code.
    • Isolated desktop terminal env tests by removing unnecessary env mocks.
  • Dependencies

    • Removed @outlit/browser from app packages and cleaned bun.lock.

Written for commit 5d799ad. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Removed a third-party analytics integration and its dependencies across apps.
    • Removed the related public environment variable from example files, build, CI, and deploy workflows.
    • Simplified provider setup and startup by removing the analytics provider wrappers and related initialization/forwarding logic.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a7b7ade-4218-4ebf-9a35-d1e1da01edfb

📥 Commits

Reviewing files that changed from the base of the PR and between 125ab5e and 5d799ad.

📒 Files selected for processing (1)
  • apps/desktop/src/main/lib/terminal/index.test.ts
💤 Files with no reviewable changes (1)
  • apps/desktop/src/main/lib/terminal/index.test.ts

📝 Walkthrough

Walkthrough

Removed Outlit Analytics integration across the repo: deleted NEXT_PUBLIC_OUTLIT_KEY usages, removed @outlit/browser dependencies, eliminated Outlit provider components and helper code, and stopped injecting the secret into CI/CD and deploy workflows.

Changes

Cohort / File(s) Summary
Env & config
\.env\.example, apps/docs/src/env.ts, apps/marketing/src/env.ts, apps/web/src/env.ts
Removed NEXT_PUBLIC_OUTLIT_KEY from example and runtime/client Zod schemas.
CI / CD workflows
.github/workflows/build-desktop.yml, .github/workflows/ci.yml, .github/workflows/deploy-preview.yml, .github/workflows/deploy-production.yml
Removed injection and CLI forwarding of NEXT_PUBLIC_OUTLIT_KEY (secrets no longer passed to build/deploy jobs).
Package manifests
apps/docs/package.json, apps/marketing/package.json, apps/web/package.json
Removed @outlit/browser dependency entries.
Providers / Layouts
apps/docs/src/app/layout.tsx, apps/docs/src/app/providers.tsx, apps/marketing/src/app/providers.tsx, apps/web/src/app/providers.tsx
Removed Outlit provider wrappers and adjusted provider trees to exclude Outlit.
Web Outlit component
apps/web/src/components/OutlitProvider/OutlitProvider.tsx, apps/web/src/components/OutlitProvider/index.ts
Deleted OutlitProvider component and its re-export.
Marketing analytics & consent
apps/marketing/src/lib/analytics/index.ts, apps/marketing/src/lib/outlit/index.ts, apps/marketing/src/components/CookieConsent/CookieConsent.tsx
Removed Outlit initialization, getOutlit() implementation, forwarding of events to Outlit, and Outlit-related consent calls; retained PostHog calls.
Tests
apps/desktop/src/main/lib/terminal/index.test.ts
Removed Bun mocks for ./env (prewarm/build env mocks); tests now rely on real module or other mocks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I hopped through code with nimble feet,

Outlit traces swept away so neat,
Providers unwrapped, secrets set free,
A lighter hop in CI and tree,
Cheers from this rabbit — witty and fleet!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove remaining Outlit integration' directly and clearly summarizes the main objective of the changeset: removal of Outlit integration across multiple applications and workflows.
Description check ✅ Passed The PR description includes a summary of changes, testing commands, and auto-generated context. While it deviates from the template structure by omitting explicit sections like 'Related Issues' and 'Type of Change', it provides comprehensive coverage of what was changed, how it was tested, and the rationale for the changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 21 files

@Kitenite Kitenite merged commit 35e12bb into superset-sh:main Mar 21, 2026
19 of 23 checks passed
@Kitenite Kitenite deleted the kitenite/check-outlit-key branch March 21, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant