Skip to content

feat(desktop): fix some tooltips and gap#270

Merged
Kitenite merged 1 commit intomainfrom
global-condor-d1b983
Dec 6, 2025
Merged

feat(desktop): fix some tooltips and gap#270
Kitenite merged 1 commit intomainfrom
global-condor-d1b983

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Dec 6, 2025

Summary

  • Replace native title attributes with Tooltip components in OpenInButton and HelpMenu
  • Adjust TopBar spacing to accommodate tooltip changes
  • Provides more polished, consistent tooltip UX across the desktop app

Test plan

  • Verify tooltips appear on hover for the "Open in" button
  • Verify tooltip appears on hover for the Help menu icon
  • Confirm tooltips display correct text including keyboard shortcuts

🤖 Generated with Claude Code

Summary by CodeRabbit

  • UI/UX Improvements
    • Added interactive tooltips to the "Open in" button (displaying the current app name and keyboard shortcut) and Help menu trigger for enhanced user guidance on hover.
    • Refined spacing adjustments in the top bar for improved visual layout and better component alignment.

✏️ Tip: You can customize this high-level summary in your review settings.

Improve UX consistency by using Tooltip components instead of native
browser title attributes for the OpenInButton and HelpMenu components.
This provides a more polished and consistent tooltip experience.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Dec 6, 2025 7:12pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Three desktop UI components receive tooltip enhancements. OpenInButton gains a tooltip displaying "Open in {currentApp.label}" with optional keyboard shortcut indicator. HelpMenu's trigger is wrapped with a "Help" tooltip. TopBar's right-side container removes horizontal gap spacing, compacting the layout.

Changes

Cohort / File(s) Summary
Tooltip additions in top bar components
apps/desktop/src/renderer/components/OpenInButton/OpenInButton.tsx, apps/desktop/src/renderer/screens/main/components/TopBar/HelpMenu/HelpMenu.tsx
Added Tooltip wrapper components around button triggers. OpenInButton displays app name with optional shortcut hint; HelpMenu displays "Help" text. Both preserve existing button styling, icons, and event handlers.
Top bar layout adjustment
apps/desktop/src/renderer/screens/main/components/TopBar/index.tsx
Removed gap-2 spacing utility from the right-side container's className, reducing horizontal spacing between header elements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Tooltip additions follow a consistent, repetitive pattern across two files
  • Spacing removal is a single, straightforward className edit
  • No logic changes, conditional flow modifications, or state management alterations
  • Changes are purely presentational with no impact on component behavior

Possibly related PRs

  • feat(desktop): add help menu to top bar #259: Directly modifies the HelpMenu component with tooltip wrapping, introducing the tooltip pattern that this PR extends to OpenInButton.
  • New desktop UI #102: Introduces the new desktop TopBar and related renderer components that are being refined here with spacing and tooltip adjustments.
  • fix superset web url #245: Adds keyboard-shortcut tooltip hints to button triggers across the TopBar, establishing the same pattern of hover-help UI that this PR applies to additional components.

Poem

A rabbit hops with joy so bright,
Adding tooltips, left and right!
"Open in this," "Help" it says,
Spacing trimmed, our UI sways. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch global-condor-d1b983

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8b30b3 and 2feb933.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/components/OpenInButton/OpenInButton.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/TopBar/HelpMenu/HelpMenu.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/TopBar/index.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite changed the title feat(desktop): replace title attributes with Tooltip components feat(desktop): fix some tooltips and gap Dec 6, 2025
@Kitenite Kitenite merged commit 4b03824 into main Dec 6, 2025
6 of 7 checks passed
@Kitenite Kitenite deleted the global-condor-d1b983 branch December 6, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant