-
Notifications
You must be signed in to change notification settings - Fork 896
desktop (fix): init git if project has no git #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2cffe13
refactor and fixed ts errors and handle unexpected empty project
AviPeltz 6353392
Merge main into mad-lungfish-c185ce and resolve conflicts
AviPeltz 4f45ab1
Merge remote-tracking branch 'origin/main' into mad-lungfish-c185ce
AviPeltz cdc639d
merge in main and fix button
AviPeltz ef3f5b9
more fixes
AviPeltz 84f92c2
more ish
AviPeltz d79c704
aria bs
AviPeltz 3b8f5a9
lint
AviPeltz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential stale reference when returning updated project.
When updating an existing project, the function modifies the database but returns the original
projectreference from line 42, which won't reflect the updatedlastOpenedAtanddefaultBranchvalues.Consider re-fetching the project after update or constructing the return value with updated fields:
if (project) { await db.update((data) => { const p = data.projects.find((p) => p.id === project?.id); if (p) { p.lastOpenedAt = Date.now(); p.defaultBranch = defaultBranch; } }); + // Re-fetch to get updated values + project = db.data.projects.find((p) => p.mainRepoPath === mainRepoPath); }🤖 Prompt for AI Agents