git lfs fix

apps/desktop/src/lib/trpc/routers/workspaces/utils/git.test.ts

@@ -0,0 +1,121 @@
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { execSync } from "node:child_process";
+import { existsSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+// We need to test the internal functions, so we'll import the module
+// and test the exported functions that use them
+
+const TEST_DIR = join(__dirname, ".test-git-tmp");
+
+function createTestRepo(name: string): string {
+	const repoPath = join(TEST_DIR, name);
+	mkdirSync(repoPath, { recursive: true });
+	execSync("git init", { cwd: repoPath, stdio: "ignore" });
+	execSync("git config user.email 'test@test.com'", {
+		cwd: repoPath,
+		stdio: "ignore",
+	});
+	execSync("git config user.name 'Test'", { cwd: repoPath, stdio: "ignore" });
+	return repoPath;
+}
+
+describe("LFS Detection", () => {
+	beforeEach(() => {
+		mkdirSync(TEST_DIR, { recursive: true });
+	});
+
+	afterEach(() => {
+		if (existsSync(TEST_DIR)) {
+			rmSync(TEST_DIR, { recursive: true, force: true });
+		}
+	});
+
+	test("detects LFS via .git/lfs directory", async () => {
+		const repoPath = createTestRepo("lfs-dir-test");
+
+		// Create .git/lfs directory (simulates LFS being initialized)
+		mkdirSync(join(repoPath, ".git", "lfs"), { recursive: true });
+
+		// Import and test - we need to test via the exported createWorktree behavior
+		// For now, just verify the directory structure is correct
+		expect(existsSync(join(repoPath, ".git", "lfs"))).toBe(true);
+	});
+
+	test("detects LFS via root .gitattributes", async () => {
+		const repoPath = createTestRepo("lfs-gitattributes-test");
+
+		// Create .gitattributes with LFS filter
+		writeFileSync(
+			join(repoPath, ".gitattributes"),
+			"*.bin filter=lfs diff=lfs merge=lfs -text\n",
+		);
+
+		const content = await Bun.file(join(repoPath, ".gitattributes")).text();
+		expect(content.includes("filter=lfs")).toBe(true);
+	});
+
+	test("detects LFS via .git/info/attributes", async () => {
+		const repoPath = createTestRepo("lfs-info-attributes-test");
+
+		// Create .git/info/attributes with LFS filter
+		mkdirSync(join(repoPath, ".git", "info"), { recursive: true });
+		writeFileSync(
+			join(repoPath, ".git", "info", "attributes"),
+			"*.png filter=lfs diff=lfs merge=lfs -text\n",
+		);
+
+		const content = await Bun.file(
+			join(repoPath, ".git", "info", "attributes"),
+		).text();
+		expect(content.includes("filter=lfs")).toBe(true);
+	});
+
+	test("detects LFS via .lfsconfig", async () => {
+		const repoPath = createTestRepo("lfs-config-test");
+
+		// Create .lfsconfig
+		writeFileSync(
+			join(repoPath, ".lfsconfig"),
+			"[lfs]\n\turl = https://example.com/lfs\n",
+		);
+
+		const content = await Bun.file(join(repoPath, ".lfsconfig")).text();
+		expect(content.includes("[lfs]")).toBe(true);
+	});
+
+	test("no LFS detected in plain repo", async () => {
+		const repoPath = createTestRepo("no-lfs-test");
+
+		// Just a plain repo with no LFS
+		expect(existsSync(join(repoPath, ".git", "lfs"))).toBe(false);
+		expect(existsSync(join(repoPath, ".gitattributes"))).toBe(false);
+	});
+});
+
+describe("Shell Environment", () => {
+	test("getShellEnvironment returns PATH", async () => {
+		const { getShellEnvironment } = await import("./shell-env");
+
+		const env = await getShellEnvironment();
+
+		// Should have PATH
+		expect(env.PATH || env.Path).toBeDefined();
+	});
+
+	test("clearShellEnvCache clears cache", async () => {
+		const { clearShellEnvCache, getShellEnvironment } = await import(
+			"./shell-env"
+		);
+
+		// Get env (populates cache)
+		await getShellEnvironment();
+
+		// Clear cache
+		clearShellEnvCache();
+
+		// Should work again (cache was cleared)
+		const env = await getShellEnvironment();
+		expect(env.PATH || env.Path).toBeDefined();
+	});
+});

apps/desktop/src/lib/trpc/routers/workspaces/utils/git.ts

@@ -1,12 +1,121 @@
+import { execFile } from "node:child_process";
 import { randomBytes } from "node:crypto";
-import { mkdir } from "node:fs/promises";
+import { mkdir, readFile, stat } from "node:fs/promises";
 import { join } from "node:path";
+import { promisify } from "node:util";
 import simpleGit from "simple-git";
 import {
 	adjectives,
 	animals,
 	uniqueNamesGenerator,
 } from "unique-names-generator";
+import { checkGitLfsAvailable, getShellEnvironment } from "./shell-env";
+
+const execFileAsync = promisify(execFile);
+
+/**
+ * Builds the merged environment for git operations.
+ * Takes process.env as base, then overrides only PATH from shell environment.
+ * This preserves runtime vars (git credentials, proxy, ELECTRON_*, etc.)
+ * while picking up PATH modifications from shell profiles (e.g., homebrew git-lfs).
+ */
+async function getGitEnv(): Promise<Record<string, string>> {
+	const shellEnv = await getShellEnvironment();
+	const result: Record<string, string> = {};
+
+	// Start with process.env as base
+	for (const [key, value] of Object.entries(process.env)) {
+		if (typeof value === "string") {
+			result[key] = value;
+		}
+	}
+
+	// Only override PATH from shell env (use platform-appropriate key)
+	const pathKey = process.platform === "win32" ? "Path" : "PATH";
+	if (shellEnv[pathKey]) {
+		result[pathKey] = shellEnv[pathKey];
+	}
+
+	return result;
+}
+
+/**
+ * Checks if a repository uses Git LFS using a hybrid approach:
+ * 1. Fast path: check if .git/lfs directory exists (LFS already initialized)
+ * 2. Check multiple attribute sources for filter=lfs:
+ *    - Root .gitattributes
+ *    - .git/info/attributes (local overrides)
+ *    - .lfsconfig (LFS-specific config)
+ * 3. Final fallback: check git config for LFS filter (catches nested .gitattributes)
+ */
+async function repoUsesLfs(repoPath: string): Promise<boolean> {
+	// Fast path: .git/lfs exists when LFS is initialized or objects fetched
+	try {
+		const lfsDir = join(repoPath, ".git", "lfs");
+		const stats = await stat(lfsDir);
+		if (stats.isDirectory()) {
+			return true;
+		}
+	} catch (error) {
+		if (!isEnoent(error)) {
+			console.warn(`[git] Could not check .git/lfs directory: ${error}`);
+		}
+	}
+
+	// Check multiple attribute sources for filter=lfs
+	const attributeFiles = [
+		join(repoPath, ".gitattributes"),
+		join(repoPath, ".git", "info", "attributes"),
+		join(repoPath, ".lfsconfig"),
+	];
+
+	for (const filePath of attributeFiles) {
+		try {
+			const content = await readFile(filePath, "utf-8");
+			if (content.includes("filter=lfs") || content.includes("[lfs]")) {
+				return true;
+			}
+		} catch (error) {
+			if (!isEnoent(error)) {
+				console.warn(`[git] Could not read ${filePath}: ${error}`);
+			}
+		}
+	}
+
+	// Final fallback: sample a few tracked files with git check-attr
+	// This catches nested .gitattributes that declare filter=lfs
+	try {
+		const git = simpleGit(repoPath);
+		// Get a small sample of tracked files (limit to 20 for performance)
+		const lsFiles = await git.raw(["ls-files"]);
+		const sampleFiles = lsFiles.split("\n").filter(Boolean).slice(0, 20);
+
+		if (sampleFiles.length > 0) {
+			// Check filter attribute on sampled files
+			const checkAttr = await git.raw([
+				"check-attr",
+				"filter",
+				"--",
+				...sampleFiles,
+			]);
+			if (checkAttr.includes("filter: lfs")) {
+				return true;
+			}
+		}
+	} catch {
+		// If git commands fail, assume no LFS to avoid blocking
+	}
+
+	return false;
+}
+
+function isEnoent(error: unknown): boolean {
+	return (
+		error instanceof Error &&
+		"code" in error &&
+		(error as NodeJS.ErrnoException).code === "ENOENT"
+	);
+}
 
 export function generateBranchName(): string {
 	const name = uniqueNamesGenerator({
@@ -26,19 +135,72 @@ export async function createWorktree(
 	worktreePath: string,
 	startPoint = "origin/main",
 ): Promise<void> {
+	// Check LFS usage before try block so it's available in catch for error messaging
+	const usesLfs = await repoUsesLfs(mainRepoPath);
+
 	try {
 		const parentDir = join(worktreePath, "..");
 		await mkdir(parentDir, { recursive: true });
 
-		const git = simpleGit(mainRepoPath);
-		await git.raw(["worktree", "add", worktreePath, "-b", branch, startPoint]);
+		// Get merged environment (process.env + shell env for PATH)
+		const env = await getGitEnv();
+
+		// Proactive LFS check: detect early if repo uses LFS but git-lfs is missing
+		if (usesLfs) {
+			const lfsAvailable = await checkGitLfsAvailable(env);
+			if (!lfsAvailable) {
+				throw new Error(
+					`This repository uses Git LFS, but git-lfs was not found. ` +
+						`Please install git-lfs (e.g., 'brew install git-lfs') and run 'git lfs install'.`,
+				);
+			}
+		}
+
+		// Use execFile with arg array for proper POSIX compatibility (no shell escaping needed)
+		await execFileAsync(
+			"git",
+			[
+				"-C",
+				mainRepoPath,
+				"worktree",
+				"add",
+				worktreePath,
+				"-b",
+				branch,
+				startPoint,
+			],
+			{ env, timeout: 120_000 },
+		);
 
 		console.log(
 			`Created worktree at ${worktreePath} with branch ${branch} from ${startPoint}`,
 		);
 	} catch (error) {
-		console.error(`Failed to create worktree: ${error}`);
-		throw new Error(`Failed to create worktree: ${error}`);
+		const errorMessage = error instanceof Error ? error.message : String(error);
+		const lowerError = errorMessage.toLowerCase();
+
+		// Broad check for LFS-related errors:
+		// - "git-lfs" / "filter-process" (original)
+		// - "smudge filter" (more specific than just "smudge" to avoid false positives)
+		// - "git: 'lfs' is not a git command"
+		// - Any mention of "lfs" when we detected LFS usage
+		const isLfsError =
+			lowerError.includes("git-lfs") ||
+			lowerError.includes("filter-process") ||
+			lowerError.includes("smudge filter") ||
+			(lowerError.includes("lfs") && lowerError.includes("not")) ||
+			(lowerError.includes("lfs") && usesLfs);
+
+		if (isLfsError) {
+			console.error(`Git LFS error during worktree creation: ${errorMessage}`);
+			throw new Error(
+				`Failed to create worktree: This repository uses Git LFS, but git-lfs was not found or failed. ` +
+					`Please install git-lfs (e.g., 'brew install git-lfs') and run 'git lfs install'.`,
+			);
+		}
+
+		console.error(`Failed to create worktree: ${errorMessage}`);
+		throw new Error(`Failed to create worktree: ${errorMessage}`);
 	}
 }
 
@@ -47,13 +209,21 @@ export async function removeWorktree(
 	worktreePath: string,
 ): Promise<void> {
 	try {
-		const git = simpleGit(mainRepoPath);
-		await git.raw(["worktree", "remove", worktreePath, "--force"]);
+		// Get merged environment (process.env + shell env for PATH)
+		const env = await getGitEnv();
+
+		// Use execFile with arg array for proper POSIX compatibility
+		await execFileAsync(
+			"git",
+			["-C", mainRepoPath, "worktree", "remove", worktreePath, "--force"],
+			{ env, timeout: 60_000 },
+		);
 
 		console.log(`Removed worktree at ${worktreePath}`);
 	} catch (error) {
-		console.error(`Failed to remove worktree: ${error}`);
-		throw new Error(`Failed to remove worktree: ${error}`);
+		const errorMessage = error instanceof Error ? error.message : String(error);
+		console.error(`Failed to remove worktree: ${errorMessage}`);
+		throw new Error(`Failed to remove worktree: ${errorMessage}`);
 	}
 }