chore(desktop): bump xterm betas

[Kitenite]

Summary

• bump the desktop xterm beta packages to the current beta line used by the app

Validation

• bunx sherif ✅
• bun run lint ✅
• bun run typecheck ✅
• NEXT_PUBLIC_OUTLIT_KEY=ci-outlit-placeholder-key bun run test ❌

Notes

• The failing test job is due to existing Bun module-loading issues in desktop tests, not files changed in this PR.
• Observed failures:
  • src/main/lib/window-state/bounds-validation.test.ts cannot resolve the named screen export from electron
  • src/lib/trpc/routers/workspaces/utils/shell-env*.test.ts, git.test.ts, teardown.test.ts, and github.test.ts cannot resolve named exports from src/lib/trpc/routers/workspaces/utils/shell-env.ts
• I did not run the desktop build after the test job failed.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR updates xterm addon dependencies to newer beta versions and refactors test infrastructure across two modules by introducing dependency injection patterns. The changes decouple modules from hard-coded Electron imports, enabling flexible mocking in tests through newly exported testing hooks.

Changes

Cohort / File(s)	Summary
Dependency Updates apps/desktop/package.json	Updated @xterm addon packages (addon-clipboard, addon-fit, addon-image, addon-ligatures, addon-search, addon-serialize, addon-unicode11, addon-webgl) and related packages from beta.148-era to beta.195-era (or beta.194), tightening version constraints.
Host Service Manager Refactoring apps/desktop/src/main/lib/host-service-manager.ts, host-service-manager.test.ts	Reworked test setup to use beforeAll/afterAll lifecycle hooks and dynamic imports instead of static mocking. Changed spawn import to namespace import (childProcess.spawn) for better mockability via spyOn interception.
Screen Dependency Injection apps/desktop/src/main/lib/window-state/bounds-validation.ts, bounds-validation.test.ts	Introduced dependency injection for Electron's screen module via new setScreenForTesting() hook and lazy-resolved getScreen() wrapper. Added TypeScript interfaces for screen API contracts. Test setup now uses setScreenForTesting(screen) to inject mock display state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 Hops through the code with testing delight,
No more hard-mocked electrons in sight!
Dependencies flow where we steer them to go,
Injection and hooks make the tests brightly glow!
Quality leaps as the mocks now align,
A refactored warren—impeccably fine! ✨

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	⚠️ Warning	The title only mentions xterm beta bumps but the PR also includes significant refactoring changes to HostServiceManager and bounds-validation testing infrastructure, making it partially related but not covering the main scope of changes.	Revise the title to reflect all major changes, such as: 'chore(desktop): bump xterm betas and stabilize CI' to better represent the full scope including testing infrastructure improvements.
Description check	❓ Inconclusive	The PR description lacks detail compared to the actual scope of changes. While it mentions bumping xterm packages, it significantly understates test infrastructure modifications made across multiple files.	Expand the description to clearly document the test infrastructure refactoring (mocking strategy changes in host-service-manager and bounds-validation), explaining why these modifications were necessary for CI stability.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 6 files