Skip to content

Use higher quality GIFs from website in README#237

Merged
saddlepaddle merged 1 commit intomainfrom
rose-storm-9
Dec 2, 2025
Merged

Use higher quality GIFs from website in README#237
saddlepaddle merged 1 commit intomainfrom
rose-storm-9

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Dec 2, 2025

Summary

  • Replace low-quality downsampled GIFs (600x353) in assets/ with full-quality versions from apps/website/public/hero/ (1836x1080)
  • Remove unused GIF files from assets/ folder

Test plan

  • Verify GIFs render correctly in README on GitHub

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated image references in README to display current visual assets for agent usage, worktree management, and terminal control.

✏️ Tip: You can customize this high-level summary in your review settings.

Replace low-quality downsampled GIFs (600x353) with full-quality
versions from the website (1836x1080) and remove unused assets.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Dec 2, 2025 1:56am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 2, 2025

Walkthrough

README.md image references updated from generic asset paths to site-specific hero image paths. Three GIF file references are changed to point to the new location within the website's public hero directory.

Changes

Cohort / File(s) Change Summary
Documentation Asset References
README.md
Updated three GIF image references: assets/example.gifapps/website/public/hero/use-agents.gif, assets/create-worktree.gifapps/website/public/hero/open-worktrees.gif, assets/create-tabs.gifapps/website/public/hero/manage-terminals.gif

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Straightforward string replacements in documentation with no logic or functional impact.

Possibly related PRs

Poem

🐰 Three images hop to their new home today,
From generic folders far away,
To the hero directory, shiny and bright,
The website now shows the perfect sight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear summary of changes but is missing critical sections from the template including Related Issues, Type of Change, and Testing verification status. Add the missing template sections: specify any related issues, mark the change type (Documentation applies here), and confirm testing completion status with checkmarks.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: replacing lower-quality GIFs in the README with higher-quality versions from the website.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rose-storm-9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saddlepaddle saddlepaddle merged commit 61410b2 into main Dec 2, 2025
6 of 7 checks passed
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
README.md (1)

1-1: Complete the test plan checklist.

The PR has an unchecked test plan item: "Verify GIFs render correctly in README on GitHub." Consider checking this off once you've confirmed the new image paths work correctly. This is especially important since GitHub's relative path handling can occasionally have edge cases.

Would you like me to help create a verification checklist or document the testing steps for this PR?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a7d3410 and ed5760e.

⛔ Files ignored due to path filters (4)
  • assets/change-themes.gif is excluded by !**/*.gif
  • assets/create-tabs.gif is excluded by !**/*.gif
  • assets/create-worktree.gif is excluded by !**/*.gif
  • assets/example.gif is excluded by !**/*.gif
📒 Files selected for processing (1)
  • README.md (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-24T21:32:21.725Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: apps/desktop/CLAUDE.md:0-0
Timestamp: 2025-11-24T21:32:21.725Z
Learning: Applies to apps/desktop/**/AGENTS.md : Document agent responsibilities, capabilities, and interaction patterns in AGENTS.md

Applied to files:

  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (1)
README.md (1)

19-19: All new GIF files are present at the specified paths.

✓ New GIF files confirmed to exist:

  • apps/website/public/hero/use-agents.gif
  • apps/website/public/hero/open-worktrees.gif
  • apps/website/public/hero/manage-terminals.gif

✓ Old GIF files from assets/ have been removed.

The markdown references in README.md (lines 19, 56, 65) correctly point to the new paths. Quality verification (1836×1080 full-resolution vs 600×353 downsampled) cannot be confirmed in the verification environment but the file integrity check passes.

Comment thread README.md
Spin up new coding tasks while waiting for your current agent to finish. Quickly switch between tasks as they need your attention.

<img alt="example" src="assets/example.gif" />
<img alt="example" src="apps/website/public/hero/use-agents.gif" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update alt text to match the semantic content of the image filename.

Line 19 has alt text "example" but the file is now use-agents.gif. The alt text should be more descriptive and consistent with the actual content shown.

Apply this diff to improve the alt text:

-<img alt="example" src="apps/website/public/hero/use-agents.gif" />
+<img alt="Using Superset agents" src="apps/website/public/hero/use-agents.gif" />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<img alt="example" src="apps/website/public/hero/use-agents.gif" />
<img alt="Using Superset agents" src="apps/website/public/hero/use-agents.gif" />
🤖 Prompt for AI Agents
README.md around line 19: the img tag's alt text is currently "example" which
doesn't reflect the file use-agents.gif; update the alt attribute to a
descriptive, semantic value matching the image (e.g., alt="Use Agents demo" or
similar) so the tag becomes consistent with the filename and conveys the image
content.

@Kitenite Kitenite deleted the rose-storm-9 branch December 2, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant