feat: initial windows support

apps/desktop/scripts/copy-native-modules.ts

@@ -96,8 +96,8 @@ function copyModuleIfSymlink(
 		console.log(`  ${moduleName}: symlink -> replacing with real files`);
 		console.log(`    Real path: ${realPath}`);
 
-		// Remove the symlink
-		rmSync(modulePath);
+		// Remove the symlink (recursive needed on Windows for junction/symlink dirs)
+		rmSync(modulePath, { recursive: true, force: true });
 
 		// Copy the actual files
 		cpSync(realPath, modulePath, { recursive: true });

apps/desktop/src/lib/trpc/routers/external/helpers.ts

@@ -43,7 +43,7 @@ const BUNDLE_ID_CANDIDATES: Partial<Record<ExternalApp, string[]>> = {
 };
 
 /** Map of app IDs to their Linux CLI commands */
-const LINUX_CLI_COMMANDS: Record<ExternalApp, string | null> = {
+const CLI_COMMANDS: Record<ExternalApp, string | null> = {
 	finder: null, // Handled specially with shell.showItemInFolder
 	vscode: "code",
 	"vscode-insiders": "code-insiders",
@@ -77,7 +77,7 @@ const LINUX_CLI_COMMANDS: Record<ExternalApp, string | null> = {
  * JetBrains Toolbox typically creates `idea`/`pycharm` launchers,
  * while package managers may use edition-specific names.
  */
-const LINUX_CLI_CANDIDATES: Partial<Record<ExternalApp, string[]>> = {
+const CLI_CANDIDATES: Partial<Record<ExternalApp, string[]>> = {
 	intellij: ["idea", "intellij-idea-ultimate", "intellij-idea-community"],
 	pycharm: ["pycharm", "pycharm-professional", "pycharm-community"],
 };
@@ -109,16 +109,33 @@ export function getAppCommand(
 		return [{ command: "open", args: ["-a", appName, targetPath] }];
 	}
 
-	// Linux (and other non-macOS platforms)
-	const linuxCandidates = LINUX_CLI_CANDIDATES[app];
+	if (platform === "win32") {
+		if (app === "finder") {
+			return [{ command: "explorer.exe", args: [targetPath] }];
+		}
+
+		const winCandidates = CLI_CANDIDATES[app];
+		if (winCandidates) {
+			return winCandidates.map((cmd) => ({
+				command: cmd,
+				args: [targetPath],
+			}));
+		}
+
+		const winCommand = CLI_COMMANDS[app];
+		if (!winCommand) return null;
+		return [{ command: winCommand, args: [targetPath] }];
+	}
+
+	const linuxCandidates = CLI_CANDIDATES[app];
 	if (linuxCandidates) {
 		return linuxCandidates.map((cmd) => ({
 			command: cmd,
 			args: [targetPath],
 		}));
 	}
 
-	const cliCommand = LINUX_CLI_COMMANDS[app];
+	const cliCommand = CLI_COMMANDS[app];
 	if (!cliCommand) return null;
 	return [{ command: cliCommand, args: [targetPath] }];
 }
@@ -149,9 +166,11 @@ const TRAILING_PUNCTUATION = /[.,;:!?]+$/;
 function looksLikePath(str: string): boolean {
 	return (
 		str.includes("/") ||
+		str.includes("\\") ||
 		str.startsWith(".") ||
 		str.startsWith("~") ||
-		str.startsWith("/")
+		str.startsWith("/") ||
+		/^[A-Za-z]:/.test(str)
 	);
 }
 

apps/desktop/src/lib/trpc/routers/workspaces/utils/shell-env.ts

@@ -60,6 +60,10 @@ interface GetShellEnvironmentOptions {
 export async function getShellEnvironment(
 	options?: GetShellEnvironmentOptions,
 ): Promise<Record<string, string>> {
+	if (process.platform === "win32") {
+		return copyStringEnv();
+	}
+
 	const now = Date.now();
 	const ttl = isFallbackCache ? fallbackCacheTtlMs : CACHE_TTL_MS;
 	if (!options?.forceRefresh && cachedEnv && now - cacheTime < ttl) {

apps/desktop/src/main/lib/agent-setup/shell-wrappers.ts

@@ -335,6 +335,9 @@ export function getShellArgs(
 	if (["zsh", "sh", "ksh"].includes(shellName)) {
 		return ["-l"];
 	}
+	if (["powershell", "pwsh", "powershell.exe", "pwsh.exe"].includes(shellName)) {
+		return ["-NoLogo"];
+	}
 	return [];
 }
 
@@ -370,5 +373,11 @@ export function getCommandShellArgs(
 			`source ${quoteShellLiteral(bashRcfile)} &&\n${commandWithManagedPrelude}`,
 		];
 	}
+	if (["powershell", "pwsh", "powershell.exe", "pwsh.exe"].includes(shellName)) {
+		return ["-NoLogo", "-Command", command];
+	}
+	if (["cmd", "cmd.exe"].includes(shellName)) {
+		return ["/C", command];
+	}
 	return ["-lc", commandWithManagedPrelude];
 }

apps/desktop/src/main/lib/auto-updater.ts

@@ -21,7 +21,8 @@ function isPrereleaseBuild(): boolean {
 }
 
 const IS_PRERELEASE = isPrereleaseBuild();
-const IS_AUTO_UPDATE_PLATFORM = PLATFORM.IS_MAC || PLATFORM.IS_LINUX;
+const IS_AUTO_UPDATE_PLATFORM =
+	PLATFORM.IS_MAC || PLATFORM.IS_LINUX || PLATFORM.IS_WINDOWS;
 
 // Use explicit feed URLs to ensure we always fetch platform-specific manifests
 // (for example latest-mac.yml and latest-linux.yml) from the correct release.

apps/desktop/src/main/lib/host-service-manager.ts

@@ -128,6 +128,7 @@ export class HostServiceManager {
 
 			const child = childProcess.spawn(process.execPath, [this.scriptPath], {
 				stdio: ["ignore", "pipe", "pipe", "ipc"],
+				windowsHide: true,
 				env,
 			});
 			instance.process = child;

apps/desktop/src/main/lib/terminal-host/client.ts

@@ -28,6 +28,7 @@ import { homedir } from "node:os";
 import { join } from "node:path";
 import { app } from "electron";
 import { SUPERSET_DIR_NAME } from "shared/constants";
+import { getSocketPath, isFileBasedSocket, socketMayExist } from "./paths";
 import { throwIfAborted } from "../terminal/abort";
 import { TerminalAttachCanceledError } from "../terminal/errors";
 import {
@@ -72,7 +73,7 @@ const DEBUG_CLIENT = process.env.SUPERSET_TERMINAL_DEBUG === "1";
 // Get from shared constants for multi-worktree support (imported at top of file)
 const SUPERSET_HOME_DIR = join(homedir(), SUPERSET_DIR_NAME);
 
-const SOCKET_PATH = join(SUPERSET_HOME_DIR, "terminal-host.sock");
+const SOCKET_PATH = getSocketPath(SUPERSET_DIR_NAME, SUPERSET_HOME_DIR);
 const TOKEN_PATH = join(SUPERSET_HOME_DIR, "terminal-host.token");
 const PID_PATH = join(SUPERSET_HOME_DIR, "terminal-host.pid");
 const SPAWN_LOCK_PATH = join(SUPERSET_HOME_DIR, "terminal-host.spawn.lock");
@@ -496,7 +497,7 @@ export class TerminalHostClient extends EventEmitter {
 
 	private async tryConnectControl(): Promise<boolean> {
 		return new Promise((resolve) => {
-			if (!existsSync(SOCKET_PATH)) {
+			if (!socketMayExist(SOCKET_PATH)) {
 				resolve(false);
 				return;
 			}
@@ -544,7 +545,7 @@ export class TerminalHostClient extends EventEmitter {
 
 	private async tryConnectStream(): Promise<boolean> {
 		return new Promise((resolve) => {
-			if (!existsSync(SOCKET_PATH)) {
+			if (!socketMayExist(SOCKET_PATH)) {
 				resolve(false);
 				return;
 			}
@@ -898,7 +899,7 @@ export class TerminalHostClient extends EventEmitter {
 	}: {
 		killSessions?: boolean;
 	} = {}): Promise<void> {
-		if (!existsSync(SOCKET_PATH)) return;
+		if (!socketMayExist(SOCKET_PATH)) return;
 
 		const token = this.readAuthToken();
 
@@ -993,7 +994,7 @@ export class TerminalHostClient extends EventEmitter {
 		const timeoutMs = 2000;
 
 		while (Date.now() - startTime < timeoutMs) {
-			if (!existsSync(SOCKET_PATH)) return;
+			if (!socketMayExist(SOCKET_PATH)) return;
 			const live = await this.isSocketLive();
 			if (!live) return;
 			await this.sleep(100);
@@ -1010,7 +1011,7 @@ export class TerminalHostClient extends EventEmitter {
 	 */
 	private isSocketLive(): Promise<boolean> {
 		return new Promise((resolve) => {
-			if (!existsSync(SOCKET_PATH)) {
+			if (!socketMayExist(SOCKET_PATH)) {
 				resolve(false);
 				return;
 			}
@@ -1092,7 +1093,9 @@ export class TerminalHostClient extends EventEmitter {
 	private async spawnDaemon(): Promise<void> {
 		// Check if socket is live first - this is the authoritative check
 		// PID file can be stale if daemon crashed and PID was reused by another process
-		if (existsSync(SOCKET_PATH)) {
+		const socketFileExists =
+			socketMayExist(SOCKET_PATH);
+		if (socketFileExists) {
 			const isLive = await this.isSocketLive();
 			if (isLive) {
 				if (DEBUG_CLIENT) {
@@ -1102,13 +1105,16 @@ export class TerminalHostClient extends EventEmitter {
 			}
 
 			// Socket exists but not responsive - safe to remove
-			if (DEBUG_CLIENT) {
-				console.log("[TerminalHostClient] Removing stale socket file");
-			}
-			try {
-				unlinkSync(SOCKET_PATH);
-			} catch {
-				// Ignore - might not have permission
+			// On Windows, named pipes are managed by the OS and don't need manual cleanup
+			if (isFileBasedSocket()) {
+				if (DEBUG_CLIENT) {
+					console.log("[TerminalHostClient] Removing stale socket file");
+				}
+				try {
+					unlinkSync(SOCKET_PATH);
+				} catch {
+					// Ignore - might not have permission
+				}
 			}
 		}
 
@@ -1190,6 +1196,7 @@ export class TerminalHostClient extends EventEmitter {
 			try {
 				child = spawn(process.execPath, [daemonScript], {
 					detached: true,
+					windowsHide: true,
 					stdio: logFd >= 0 ? ["ignore", logFd, logFd] : "ignore",
 					env: {
 						...process.env,
@@ -1260,10 +1267,16 @@ export class TerminalHostClient extends EventEmitter {
 		const startTime = Date.now();
 
 		while (Date.now() - startTime < SPAWN_WAIT_MS) {
-			if (existsSync(SOCKET_PATH)) {
-				// Give it a moment to start listening
-				await this.sleep(200);
-				return;
+			if (isFileBasedSocket()) {
+				// Unix: check if socket file appeared on disk
+				if (existsSync(SOCKET_PATH)) {
+					await this.sleep(200);
+					return;
+				}
+			} else {
+				// Windows: named pipes don't exist as files, try connecting
+				const live = await this.isSocketLive();
+				if (live) return;
 			}
 			await this.sleep(100);
 		}

apps/desktop/src/main/lib/terminal-host/paths.ts

@@ -0,0 +1,36 @@
+import { existsSync } from "node:fs";
+import { join } from "node:path";
+import { PLATFORM } from "shared/constants";
+
+/**
+ * Returns the IPC socket/pipe path for the terminal host daemon.
+ * On Unix, this is a Unix domain socket file inside the superset home directory.
+ * On Windows, this is a named pipe (named pipes don't exist as files on disk).
+ */
+export function getSocketPath(
+	supersetDirName: string,
+	supersetHomeDir: string,
+): string {
+	if (PLATFORM.IS_WINDOWS) {
+		return `\\\\?\\pipe\\superset-terminal-host-${supersetDirName}`;
+	}
+	return join(supersetHomeDir, "terminal-host.sock");
+}
+
+/**
+ * Whether the IPC transport uses a file-based socket (Unix domain socket)
+ * rather than a named pipe. Only file-based sockets can be checked with `existsSync`.
+ */
+export function isFileBasedSocket(): boolean {
+	return !PLATFORM.IS_WINDOWS;
+}
+
+/**
+ * Checks whether the IPC socket/pipe exists.
+ * On Unix, checks for the socket file on disk.
+ * On Windows, named pipes can't be checked via the filesystem, so assumes true.
+ */
+export function socketMayExist(socketPath: string): boolean {
+	if (!isFileBasedSocket()) return true;
+	return existsSync(socketPath);
+}

apps/desktop/src/main/lib/terminal/daemon/constants.ts

@@ -1,6 +1,6 @@
 export const SESSION_CLEANUP_DELAY_MS = 5000;
 export const DEBUG_TERMINAL = process.env.SUPERSET_TERMINAL_DEBUG === "1";
 export const CREATE_OR_ATTACH_CONCURRENCY = 3;
-export const MAX_SCROLLBACK_BYTES = 500_000;
+export const MAX_SCROLLBACK_BYTES = 150_000;
 export const MAX_HISTORY_SCROLLBACK_BYTES = 512 * 1024;
 export const MAX_KILLED_SESSION_TOMBSTONES = 1000;

apps/desktop/src/main/lib/terminal/env.ts

@@ -19,6 +19,11 @@ let cachedMacosSystemCertAvailable: boolean | null = null;
 
 function startLocaleProbe(): void {
 	if (cachedUtf8Locale || localeProbeInFlight) return;
+	// The `locale` command does not exist on Windows
+	if (os.platform() === "win32") {
+		cachedUtf8Locale = "en_US.UTF-8";
+		return;
+	}
 	localeProbeInFlight = true;
 
 	exec(
@@ -42,7 +47,8 @@ function startLocaleProbe(): void {
  */
 export const HOOK_PROTOCOL_VERSION = "2";
 
-export const FALLBACK_SHELL = os.platform() === "win32" ? "cmd.exe" : "/bin/sh";
+export const FALLBACK_SHELL =
+	os.platform() === "win32" ? "powershell.exe" : "/bin/sh";
 export const SHELL_CRASH_THRESHOLD_MS = 1000;
 
 type DefaultShellModuleShape =
@@ -73,15 +79,18 @@ export function normalizeDefaultShell(
 }
 
 export function getDefaultShell(): string {
-	const resolvedDefaultShell = normalizeDefaultShell(defaultShell);
-	if (resolvedDefaultShell) {
-		return resolvedDefaultShell;
-	}
-
 	const platform = os.platform();
 
+	// On Windows, always use PowerShell. The `default-shell` package returns
+	// COMSPEC (cmd.exe), which can't handle the subexpressions and file-read
+	// syntax used by agent launch commands.
 	if (platform === "win32") {
-		return process.env.COMSPEC || "powershell.exe";
+		return "powershell.exe";
+	}
+
+	const resolvedDefaultShell = normalizeDefaultShell(defaultShell);
+	if (resolvedDefaultShell) {
+		return resolvedDefaultShell;
 	}
 
 	if (process.env.SHELL) {

apps/desktop/src/main/lib/terminal/port-scanner.ts

@@ -121,6 +121,7 @@ async function getListeningPortsWindows(pids: number[]): Promise<PortInfo[]> {
 		const { stdout: output } = await execAsync("netstat -ano", {
 			maxBuffer: 10 * 1024 * 1024,
 			timeout: EXEC_TIMEOUT_MS,
+			windowsHide: true,
 		});
 
 		const pidSet = new Set(pids);
@@ -199,7 +200,7 @@ async function getProcessNameWindows(pid: number): Promise<string> {
 	try {
 		const { stdout: output } = await execAsync(
 			`wmic process where processid=${pid} get name 2>nul`,
-			{ timeout: EXEC_TIMEOUT_MS },
+			{ timeout: EXEC_TIMEOUT_MS, windowsHide: true },
 		);
 		const lines = output.trim().split("\n");
 		if (lines.length >= 2) {
@@ -211,7 +212,7 @@ async function getProcessNameWindows(pid: number): Promise<string> {
 		try {
 			const { stdout: output } = await execAsync(
 				`powershell -Command "(Get-Process -Id ${pid}).ProcessName"`,
-				{ timeout: EXEC_TIMEOUT_MS },
+				{ timeout: EXEC_TIMEOUT_MS, windowsHide: true },
 			);
 			return output.trim() || "unknown";
 		} catch {}