Skip to content

Add tooltips with keyboard shortcuts to topbar buttons #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AviPeltz merged 1 commit into from
Dec 2, 2025
Merged

Add tooltips with keyboard shortcuts to topbar buttons #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions apps/desktop/src/renderer/screens/main/components/TopBar/SettingsButton/SettingsButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,35 @@
import { Kbd, KbdGroup } from "@superset/ui/kbd";
import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip";
import { HiOutlineCog6Tooth } from "react-icons/hi2";
import { useOpenSettings } from "renderer/stores";
import { formatKeysForDisplay, HOTKEYS } from "shared/hotkeys";

export function SettingsButton() {
const openSettings = useOpenSettings();
const keys = formatKeysForDisplay(HOTKEYS.SHOW_HOTKEYS.keys);

return (
<button
type="button"
onClick={() => openSettings()}
className="no-drag flex h-8 w-8 items-center justify-center rounded-md text-accent-foreground hover:bg-accent hover:text-accent-foreground transition-colors"
aria-label="Open settings"
>
<HiOutlineCog6Tooth className="h-4 w-4" />
</button>
<Tooltip>
<TooltipTrigger asChild>
<button
type="button"
onClick={() => openSettings()}
className="no-drag flex h-8 w-8 items-center justify-center rounded-md text-accent-foreground hover:bg-accent hover:text-accent-foreground transition-colors"
aria-label="Open settings"
>
<HiOutlineCog6Tooth className="h-4 w-4" />
</button>
</TooltipTrigger>
<TooltipContent side="bottom" showArrow={false}>
<span className="flex items-center gap-2">
Settings
<KbdGroup>
{keys.map((key) => (
<Kbd key={key}>{key}</Kbd>
))}
</KbdGroup>
</span>
</TooltipContent>
</Tooltip>
);
}
44 changes: 31 additions & 13 deletions apps/desktop/src/renderer/screens/main/components/TopBar/SidebarControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,41 @@
import { Button } from "@superset/ui/button";
import { Kbd, KbdGroup } from "@superset/ui/kbd";
import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip";
import { HiMiniBars3, HiMiniBars3BottomLeft } from "react-icons/hi2";
import { useSidebarStore } from "renderer/stores";
import { formatKeysForDisplay, HOTKEYS } from "shared/hotkeys";

export function SidebarControl() {
const { isSidebarOpen, toggleSidebar } = useSidebarStore();
const keys = formatKeysForDisplay(HOTKEYS.TOGGLE_SIDEBAR.keys);

return (
<Button
variant="ghost"
size="icon"
onClick={toggleSidebar}
aria-label="Toggle sidebar"
className="no-drag"
>
{isSidebarOpen ? (
<HiMiniBars3BottomLeft className="size-4" />
) : (
<HiMiniBars3 className="size-4" />
)}
</Button>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
onClick={toggleSidebar}
aria-label="Toggle sidebar"
className="no-drag"
>
{isSidebarOpen ? (
<HiMiniBars3BottomLeft className="size-4" />
) : (
<HiMiniBars3 className="size-4" />
)}
</Button>
</TooltipTrigger>
<TooltipContent side="bottom" showArrow={false}>
<span className="flex items-center gap-2">
Toggle sidebar
<KbdGroup>
{keys.map((key) => (
<Kbd key={key}>{key}</Kbd>
))}
</KbdGroup>
</span>
</TooltipContent>
</Tooltip>
);
}