Skip to content

fix(desktop): restore popover colors on new workspace modal#2254

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/placid-nigella
Mar 8, 2026
Merged

fix(desktop): restore popover colors on new workspace modal#2254
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/placid-nigella

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Mar 8, 2026

Summary

  • Adds bg-popover text-popover-foreground to the DialogContent in the New Workspace modal
  • When fix(desktop): restore new workspace modal persistence #2225 switched from CommandDialog to Dialog/DialogContent (to fix textarea keyboard behavior), it lost the popover colors that Command previously provided — the modal background fell back to bg-background instead of bg-popover

Test plan

  • Open the New Workspace modal and verify colors are consistent across all tabs (Prompt, Issues, PRs, Branches)
  • Verify the modal background matches the command list area

Summary by cubic

Restores popover colors in the New Workspace modal by adding bg-popover and text-popover-foreground to DialogContent. This fixes the regression from switching to Dialog and keeps the modal consistent across tabs and with the command list area.

Written for commit 234f551. Summary will update on new commits.

Summary by CodeRabbit

  • Style
    • Enhanced the New Workspace Modal's visual appearance with updated color styling for improved visual consistency.

The switch from CommandDialog to Dialog/DialogContent in #2225 lost the
bg-popover/text-popover-foreground colors that Command previously provided,
causing the modal background to use bg-background instead.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7590bc0e-46f3-4438-ac83-c1bfd7aa38c0

📥 Commits

Reviewing files that changed from the base of the PR and between 86dd0d8 and 234f551.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx

📝 Walkthrough

Walkthrough

Adds two CSS utility classes (bg-popover and text-popover-foreground) to the DialogContent component in NewWorkspaceModal, enhancing visual styling with popover-themed colors without affecting component logic.

Changes

Cohort / File(s) Summary
Modal Styling Enhancement
apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx
Augments DialogContent with popover background and foreground text utility classes for improved visual theming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With whiskers twitched and paws on keys,
I've dressed the modal, if you please!
Popover colors, soft and true,
Now dialogs shine in cleaner hue. ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch saddlepaddle/placid-nigella

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@saddlepaddle saddlepaddle merged commit 0a14f63 into main Mar 8, 2026
6 of 7 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 8, 2026

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

@Kitenite Kitenite deleted the saddlepaddle/placid-nigella branch March 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant