fix(desktop): restore popover colors on new workspace modal#2254
Conversation
The switch from CommandDialog to Dialog/DialogContent in #2225 lost the bg-popover/text-popover-foreground colors that Command previously provided, causing the modal background to use bg-background instead.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds two CSS utility classes ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
bg-popover text-popover-foregroundto theDialogContentin the New Workspace modalCommandDialogtoDialog/DialogContent(to fix textarea keyboard behavior), it lost the popover colors thatCommandpreviously provided — the modal background fell back tobg-backgroundinstead ofbg-popoverTest plan
Summary by cubic
Restores popover colors in the New Workspace modal by adding
bg-popoverandtext-popover-foregroundtoDialogContent. This fixes the regression from switching toDialogand keeps the modal consistent across tabs and with the command list area.Written for commit 234f551. Summary will update on new commits.
Summary by CodeRabbit