Skip to content

fix(ci): add generate:icons step to desktop build #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 3 commits into from
Mar 7, 2026
+8 −0
Merged

fix(ci): add generate:icons step to desktop build #2164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10e16dc
chore(desktop): bump version to 1.1.0
Kitenite Mar 7, 2026
fa4da25
fix(ci): add generate:icons step before compile in desktop build
Kitenite Mar 7, 2026
49670ce
revert: remove version bump from this PR
Kitenite Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ jobs:
working-directory: apps/desktop
run: bun run clean:dev

- name: Generate file icons
working-directory: apps/desktop
run: bun run generate:icons
Comment on lines +84 to +86
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fail the build if icon generation produced no SVG assets.

This step only checks that the script ran. apps/desktop/scripts/generate-file-icons.ts still exits 0 when referenced SVGs are missing, because it skips missing files and writes manifest.json anyway. That means CI can now get past compile:app but still publish a desktop build with broken file icons at runtime.

Suggested workflow hardening 
-      - name: Generate file icons
-        working-directory: apps/desktop
-        run: bun run generate:icons
+      - name: Generate file icons
+        working-directory: apps/desktop
+        run: |
+          bun run generate:icons
+          test -f src/resources/public/file-icons/manifest.json || {
+            echo "::error::file icon manifest was not generated"
+            exit 1
+          }
+          test -n "$(find src/resources/public/file-icons -maxdepth 1 -name '*.svg' -print -quit)" || {
+            echo "::error::no file icon SVGs were generated"
+            exit 1
+          }

Also applies to: 195-197

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-desktop.yml around lines 84 - 86, The workflow step
that runs "bun run generate:icons" allows the script to succeed even when no
SVGs are produced; update CI to fail if icon generation produced no assets by
either (A) changing apps/desktop/scripts/generate-file-icons.ts to detect
missing referenced SVGs and call process.exit(1) (or throw) when zero icons are
found or any required SVGs are missing, or (B) adding a follow-up job/step after
the existing Generate file icons step that inspects
apps/desktop/public/manifest.json (or the script’s output location) and exits
non-zero if the manifest has no entries or expected asset keys are missing;
reference the generate-file-icons.ts script, the generate:icons npm script, and
manifest.json to locate the relevant code/outputs.


- name: Compile app with electron-vite
working-directory: apps/desktop
env:
Expand Down Expand Up @@ -188,6 +192,10 @@ jobs:
working-directory: apps/desktop
run: bun run clean:dev

- name: Generate file icons
working-directory: apps/desktop
run: bun run generate:icons

- name: Compile app with electron-vite
working-directory: apps/desktop
env:
Expand Down