-
Notifications
You must be signed in to change notification settings - Fork 897
Ghostty Web #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghostty Web #2115
Changes from all commits
3334465
eb0dae1
e2e04f7
2ecc0b5
512ebd5
1131cf3
2e41fe8
953cc22
8d5e3a0
45ec31b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -112,6 +112,7 @@ app.get("/hook/complete", (req, res) => { | |||||||||
| workspaceId, | ||||||||||
| sessionId, | ||||||||||
| eventType, | ||||||||||
| notificationType, | ||||||||||
| env: clientEnv, | ||||||||||
| version, | ||||||||||
| } = req.query; | ||||||||||
|
|
@@ -133,7 +134,9 @@ app.get("/hook/complete", (req, res) => { | |||||||||
| ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| const mappedEventType = mapEventType(eventType as string | undefined); | ||||||||||
| const mappedEventType = | ||||||||||
| mapEventType(eventType as string | undefined) ?? | ||||||||||
| mapEventType(notificationType as string | undefined); | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Validate Prompt for AI agents
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Validate Prompt for AI agents |
||||||||||
|
|
||||||||||
| // Unknown or missing eventType: return success but don't process | ||||||||||
| // This ensures forward compatibility and doesn't block the agent | ||||||||||
|
|
@@ -161,6 +164,7 @@ app.get("/hook/complete", (req, res) => { | |||||||||
| if (DEBUG_HOOKS_ENABLED) { | ||||||||||
| console.log("[notifications] hook event received", { | ||||||||||
| eventType, | ||||||||||
| notificationType: notificationType as string | undefined, | ||||||||||
| mappedEventType, | ||||||||||
| paneId: paneId as string | undefined, | ||||||||||
| tabId: tabId as string | undefined, | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: The
onExithandler signature was changed to expect apayloadobject, butterminal.emitin thewriteprocedure still uses positional arguments.Prompt for AI agents