Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughThe PR adds a CODE_OF_CONDUCT, replaces CONTRIBUTING placeholder with full contribution guidance, substantially updates README content and badges, removes ENABLE_NEW_UI from desktop Vite config and TypeScript env, adjusts npm scripts for desktop-focused dev/build, and deletes the deprecated update-port.sh script. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CODE_OF_CONDUCT.md (1)
63-63: Personal email for code-of-conduct enforcement contact may present long-term maintenance concerns.The enforcement contact is listed as a personal email address (hoakiet98@gmail.com). While this is common in early-stage projects, consider whether:
- A shared team email or GitHub Discussions/Issues should be used instead for scalability and bus-factor resilience.
- A rotation or escalation policy exists if the primary contact becomes unavailable.
For a young project, this is acceptable, but plan for an organizational contact as the project grows.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
CODE_OF_CONDUCT.md(1 hunks)CONTRIBUTING.md(1 hunks)README.md(6 hunks)apps/desktop/electron.vite.config.ts(0 hunks)apps/desktop/index.d.ts(0 hunks)apps/desktop/package.json(1 hunks)package.json(1 hunks)update-port.sh(0 hunks)
💤 Files with no reviewable changes (3)
- apps/desktop/index.d.ts
- update-port.sh
- apps/desktop/electron.vite.config.ts
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-28T01:03:47.951Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-28T01:03:47.951Z
Learning: Applies to apps/desktop/electron.vite.config.ts : Load `.env` file with `override: true` in Vite configuration for build-time environment variable access
Applied to files:
apps/desktop/package.json
📚 Learning: 2025-11-28T01:03:47.951Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-28T01:03:47.951Z
Learning: Use Bun as the package manager - no npm, yarn, or pnpm
Applied to files:
apps/desktop/package.json
📚 Learning: 2025-11-28T01:03:47.951Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-28T01:03:47.951Z
Learning: Use Turborepo as the build system for managing the monorepo
Applied to files:
package.json
🪛 LanguageTool
CONTRIBUTING.md
[style] ~17-~17: Consider using a different verb to strengthen your wording.
Context: ...rs to update your PR if necessary which speeds up the review process. [See more here](htt...
(SPEED_UP_ACCELERATE)
CODE_OF_CONDUCT.md
[style] ~32-~32: Try using a synonym here to strengthen your wording.
Context: ...ind * Trolling, insulting or derogatory comments, and personal or political attacks * Pu...
(COMMENT_REMARK)
README.md
[style] ~96-~96: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 2283 characters long)
Context: ...olor=black)](https://orm.drizzle.team/) [
🪛 markdownlint-cli2 (0.18.1)
CODE_OF_CONDUCT.md
38-38: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (6)
apps/desktop/package.json (1)
23-23: Environment variable to skip code-signing is appropriate for development builds.The
CSC_IDENTITY_AUTO_DISCOVERY=falsevariable controls whether electron-builder attempts code-signing, enabling unsigned development builds. Combined with the newcross-envwrapper, this ensures cross-platform compatibility. This aligns with the README note that Superset Desktop is currently macOS-only and tested in development mode.README.md (2)
33-60: Verify Getting Started instructions and duplicated install command.The new Getting Started section provides helpful setup guidance, but has two issues:
- Line 49 duplicates
bun install(already in line 44), likely a copy-paste error.- The dev run command on line 50 uses
bun run dev, which needs verification against the root package.json to ensure it aligns with the desktop-focused dev script changes (line 18:"dev": "turbo dev --filter=@superset/desktop").Verify the Getting Started instructions against the repository's actual setup process. Confirm that:
- The
bun installduplication on line 49 should be removedbun run devcorrectly invokes the updated root-level dev script- The build output path
apps/desktop/releaseis accurate
142-142: Verify LICENSE.txt exists at repository root.The license URL reference changed from GitHub path to a relative local path
./LICENSE.txt. Confirm that the file exists in the repository root and is not namedLICENSE.mdinstead.package.json (1)
18-24: Strategic shift to desktop-focused defaults—confirm CI/CD alignment.The package.json scripts have been reorganized to make desktop development the default (
devandbuildnow filter for@superset/desktop), withdev:allas an escape hatch for full monorepo orchestration. This is a significant workflow change that requires verification:
- Confirm that CI/CD pipelines, pre-commit hooks, or automation scripts do not rely on the old
dev:desktopor previousbuildbehavior.- Ensure documentation or team communication clarifies these new defaults, especially if other workspaces still need regular development.
Per learnings, Turborepo is the build system for this monorepo. The filtering syntax used is correct.
CONTRIBUTING.md (1)
1-27: Well-structured contributing guidelines with appropriate references.The CONTRIBUTING.md provides clear, step-by-step guidance for contributors, including the fork-based PR workflow, maintainer edit permissions, and a concise style guide referencing the Boy Scout rule and Clean Code principles. The file appropriately cross-references the CODE_OF_CONDUCT.md and establishes a strong contribution culture.
A minor suggestion: Step 3 could clarify whether linking an issue is mandatory for all PRs or only for bug fixes/features.
CODE_OF_CONDUCT.md (1)
1-85: Comprehensive and industry-standard code of conduct.The Contributor Covenant 2.0 provides a complete, well-structured framework for community standards, including clear definitions of acceptable and unacceptable behavior, well-defined enforcement responsibilities, and appropriate attribution. The scope, enforcement, and privacy protections are clearly articulated and align with best practices for open-source projects.
1 participant
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.