Skip to content

Revert "feat(desktop): support big and compact terminal add buttons"#1760

Merged
Kitenite merged 1 commit into
mainfrom
revert-1757-kitenite/add-button-allow-spread
Feb 24, 2026
Merged

Revert "feat(desktop): support big and compact terminal add buttons"#1760
Kitenite merged 1 commit into
mainfrom
revert-1757-kitenite/add-button-allow-spread

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Feb 24, 2026

Reverts #1757

Summary by CodeRabbit

  • Refactor
    • Simplified the terminal add button interface by removing the presets dropdown menu and compact button toggle option.
    • Removed terminal presets feature from the application.
    • Cleaned up unused dependencies from the desktop application.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8639a1c and 5881ade.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (13)
  • apps/desktop/electron.vite.config.ts
  • apps/desktop/package.json
  • apps/desktop/src/lib/trpc/routers/settings/index.ts
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/AddTabButton.tsx
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/components/PresetsSubmenu/PresetsSubmenu.tsx
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/components/PresetsSubmenu/index.ts
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/index.ts
  • apps/desktop/src/shared/constants.ts
  • packages/local-db/drizzle/0034_add_use_big_terminal_add_button_setting.sql
  • packages/local-db/drizzle/meta/0034_snapshot.json
  • packages/local-db/drizzle/meta/_journal.json
  • packages/local-db/src/schema/schema.ts

📝 Walkthrough

Walkthrough

This PR removes the terminal add button size preference feature, including TRPC procedures, database schema, and related dependencies. The UI is refactored from an AddTabButton component to a NewTabDropZone dropdown, eliminating presets-related logic and simplifying the tab management interface.

Changes

Cohort / File(s) Summary
Build & Dependencies
apps/desktop/electron.vite.config.ts, apps/desktop/package.json
Removed mastracode and @ast-grep/napi from build externals and package dependencies; these modules will now be bundled rather than treated as external.
Settings & Configuration
apps/desktop/src/lib/trpc/routers/settings/index.ts, apps/desktop/src/shared/constants.ts
Removed TRPC procedures getUseCompactTerminalAddButton and setUseCompactTerminalAddButton, plus DEFAULT_USE_COMPACT_TERMINAL_ADD_BUTTON constant.
Database Schema & Migrations
packages/local-db/drizzle/0034_add_use_big_terminal_add_button_setting.sql, packages/local-db/drizzle/meta/0034_snapshot.json, packages/local-db/drizzle/meta/_journal.json, packages/local-db/src/schema/schema.ts
Removed database migration, snapshot metadata, journal entry, and useBigTerminalAddButton column from settings table schema.
UI Component Refactoring
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx
Replaced AddTabButton-based UI with NewTabDropZone dropdown menu offering Terminal, Chat, Browser actions and Show Preset Bar toggle; simplified overflow handling.
Deleted Components
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/AddTabButton.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/components/PresetsSubmenu/PresetsSubmenu.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/components/PresetsSubmenu/index.ts, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/components/AddTabButton/index.ts
Removed AddTabButton component, PresetsSubmenu component, and their associated index re-exports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

A button once big, now bundled away 🐰
Dependencies trim, the code finds new play
Dropdowns replace what once was a choice
The UI speaks softer, in clearer voice
Presets fade quiet—simplicity's gain ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-1757-kitenite/add-button-allow-spread

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 44da7ae into main Feb 24, 2026
5 of 7 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 24, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant