Skip to content

revert: restore Fly.io infrastructure, revert Electric Cloud migration#1720

Merged
saddlepaddle merged 1 commit into
mainfrom
revert-electric-cloud
Feb 23, 2026
Merged

revert: restore Fly.io infrastructure, revert Electric Cloud migration#1720
saddlepaddle merged 1 commit into
mainfrom
revert-electric-cloud

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Feb 23, 2026

Summary

  • Reverts chore: remove Fly.io infrastructure, use Electric Cloud #1717 which removed Fly.io deployment infrastructure and switched to Electric Cloud in production
  • Restores fly.toml, Fly-based CI deploy/preview jobs, and the self-hosted Electric proxy path
  • ELECTRIC_URL and ELECTRIC_SECRET GitHub secrets have been set to point at https://electric.superset.sh/v1/shape with a fresh shared secret (also updated on the Fly machine)

Test plan

  • Verify Electric sync works end-to-end in production after merge
  • Confirm preview deploys spin up correctly with Fly

Summary by CodeRabbit

  • New Features

    • Added support for deploying Electric to Fly.io infrastructure
    • API now supports flexible Electric backend configuration for both cloud and self-hosted deployments
  • Chores

    • Updated deployment workflows and infrastructure configuration
    • Modified service endpoint defaults for improved deployment flexibility

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 072f3f9 and 308bfe6.

📒 Files selected for processing (10)
  • .github/templates/preview-comment.md
  • .github/workflows/cleanup-preview.yml
  • .github/workflows/deploy-preview.yml
  • .github/workflows/deploy-production.yml
  • apps/api/src/app/api/electric/[...path]/route.ts
  • apps/api/src/env.ts
  • apps/api/src/proxy.ts
  • apps/desktop/electron.vite.config.ts
  • apps/desktop/src/renderer/routes/_authenticated/providers/CollectionsProvider/collections.ts
  • fly.toml

📝 Walkthrough

Walkthrough

The changes introduce Electric (Fly.io) deployment infrastructure to the system. This includes new GitHub Actions workflows for deploying and cleaning up Electric instances on Fly.io, updated API routing and environment configuration to use Electric URL endpoints, a Fly.io deployment manifest, and desktop client updates to signal Electric backend usage via headers.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/deploy-preview.yml, .github/workflows/cleanup-preview.yml, .github/workflows/deploy-production.yml, .github/templates/preview-comment.md
Added new deploy-electric job for Fly.io deployment, setup of Fly CLI for app management, Electric deployment steps with status artifact generation, cleanup steps for preview environments, and preview comment template updates to display Electric deployment status alongside Neon.
API Environment & Routing
apps/api/src/env.ts, apps/api/src/app/api/electric/[...path]/route.ts, apps/api/src/proxy.ts
Made ELECTRIC_URL and ELECTRIC_SECRET required in environment schema (previously optional), updated Electric route handler to support cloud-agnostic origin selection via x-electric-backend header, and added X-Electric-Backend to CORS allowed headers list.
Fly.io Configuration
fly.toml
New deployment manifest configuring superset-electric app on Fly.io with electricsql/electric:1.4.3 image, resource allocation (4 CPU, 8GB RAM), environment variables for Electric configuration, HTTP service settings, health checks, and persistent storage mount.
Desktop Application
apps/desktop/electron.vite.config.ts, apps/desktop/src/renderer/routes/_authenticated/providers/CollectionsProvider/collections.ts
Updated default streams URL to point to https://superset-stream.fly.dev, and added X-Electric-Backend: cloud header to all Electric API requests to signal cloud backend usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

  • superset-sh/superset#1717: Removes Fly.io-based Electric deployment in favor of Electric Cloud integration, making it a direct inverse of the infrastructure changes introduced here.

Poem

🐰 Fly high with Electric, dear friends so bright,
Workflows dance on Fly.io with all their might,
Headers signal cloud, paths redirect with care,
A hop, skip, and deploy—infrastructure in the air!

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-electric-cloud

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saddlepaddle saddlepaddle merged commit 94e17c9 into main Feb 23, 2026
12 of 13 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

@Kitenite Kitenite deleted the revert-electric-cloud branch February 27, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant