-
Notifications
You must be signed in to change notification settings - Fork 966
refactor(mcp): rename start_claude_session to start_agent_session #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7793d4f
refactor(mcp): rename start_claude_session to start_agent_session wit…
Kitenite a74a717
Lint
Kitenite 894a1cd
feat(setup): add --mcp flag to configure local MCP server
Kitenite f6c0dc7
feat(desktop): add agent selector to task view and refactor preset te…
Kitenite ad88dac
fix(desktop): remove duplicated agent icon in select trigger
Kitenite ef5e10b
fix(desktop): show agent icon in select items, not trigger
Kitenite 9a4326b
fix(desktop): use agentCommand field for separate pane instead of ini…
Kitenite 323ff2c
fix(shared): launch opencode in interactive TUI mode instead of headless
Kitenite 93f5be2
fix(shared): launch opencode in interactive mode with prompt
Kitenite 71d8cf5
fix(shared): use --prompt flag for opencode interactive mode
Kitenite 47eb26b
fix(desktop): send agent command to existing workspaces via new tab
Kitenite e0d0177
fix(shared): correct copilot and cursor-agent CLI flags for interacti…
Kitenite 02ae0ce
Deslop
Kitenite 7884253
fix: address PR review feedback for agent command safety
Kitenite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...op/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/utils/buildAgentCommand.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export { | ||
| type AgentType, | ||
| buildAgentCommand, | ||
| buildClaudeCommand, | ||
| type TaskInput, | ||
| } from "@superset/shared/agent-command"; |
1 change: 0 additions & 1 deletion
1
...p/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/utils/buildClaudeCommand.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the
renderer/alias instead of a relative path.All other imports in this file (lines 27–31) use the
renderer/alias. Line 32 uses a fragile relative path instead.🛠️ Proposed fix
As per coding guidelines: "Use alias as defined in
tsconfig.jsonwhen possible" forapps/desktop/**/*.{ts,tsx}.📝 Committable suggestion
🤖 Prompt for AI Agents