feat(desktop): add global default editor setting

apps/desktop/src/lib/trpc/routers/external/index.ts

@@ -1,4 +1,9 @@
-import { EXTERNAL_APPS, projects } from "@superset/local-db";
+import {
+	EXTERNAL_APPS,
+	NON_EDITOR_APPS,
+	projects,
+	settings,
+} from "@superset/local-db";
 import { TRPCError } from "@trpc/server";
 import { eq } from "drizzle-orm";
 import { clipboard, shell } from "electron";
@@ -14,6 +19,39 @@ import {
 
 const ExternalAppSchema = z.enum(EXTERNAL_APPS);
 
+const nonEditorSet = new Set<ExternalApp>(NON_EDITOR_APPS);
+
+/** Sets the global default editor if one hasn't been set yet. Skips non-editor apps. */
+function ensureGlobalDefaultEditor(app: ExternalApp) {
+	if (nonEditorSet.has(app)) return;
+
+	const row = localDb.select().from(settings).get();
+	if (!row?.defaultEditor) {
+		localDb
+			.insert(settings)
+			.values({ id: 1, defaultEditor: app })
+			.onConflictDoUpdate({
+				target: settings.id,
+				set: { defaultEditor: app },
+			})
+			.run();
+	}
+}
+
+/** Resolves the default editor from project setting, then global setting. */
+export function resolveDefaultEditor(projectId?: string): ExternalApp | null {
+	if (projectId) {
+		const project = localDb
+			.select()
+			.from(projects)
+			.where(eq(projects.id, projectId))
+			.get();
+		if (project?.defaultApp) return project.defaultApp;
+	}
+	const row = localDb.select().from(settings).get();
+	return row?.defaultEditor ?? null;
+}
+
 async function openPathInApp(
 	filePath: string,
 	app: ExternalApp,
@@ -80,14 +118,26 @@ export const createExternalRouter = () => {
 				}),
 			)
 			.mutation(async ({ input }) => {
+				await openPathInApp(input.path, input.app);
+
+				// Persist defaults only after successful launch
 				if (input.projectId) {
 					localDb
 						.update(projects)
 						.set({ defaultApp: input.app })
 						.where(eq(projects.id, input.projectId))
 						.run();
 				}
-				await openPathInApp(input.path, input.app);
+
+				// Auto-set global default editor on first successful use (best-effort)
+				try {
+					ensureGlobalDefaultEditor(input.app);
+				} catch (err) {
+					console.warn(
+						"[external/openInApp] Failed to persist global default editor:",
+						err,
+					);
+				}
 			}),
 
 		copyPath: publicProcedure.input(z.string()).mutation(async ({ input }) => {
@@ -106,15 +156,10 @@ export const createExternalRouter = () => {
 			)
 			.mutation(async ({ input }) => {
 				const filePath = resolvePath(input.path, input.cwd);
-				let app: ExternalApp = "cursor";
-				if (input.projectId) {
-					const project = localDb
-						.select()
-						.from(projects)
-						.where(eq(projects.id, input.projectId))
-						.get();
-					app = project?.defaultApp ?? "cursor";
-				}
+				// Preserve first-run behavior for terminal/file-link flows.
+				// If no project/global default editor is configured yet, fall back to Cursor.
+				const app = resolveDefaultEditor(input.projectId) ?? "cursor";
+
 				await openPathInApp(filePath, app);
 			}),
 	});

apps/desktop/src/lib/trpc/routers/projects/projects.ts

@@ -24,6 +24,7 @@ import { PROJECT_COLOR_VALUES } from "shared/constants/project-colors";
 import simpleGit from "simple-git";
 import { z } from "zod";
 import { publicProcedure, router } from "../..";
+import { resolveDefaultEditor } from "../external";
 import {
 	activateProject,
 	getBranchWorkspace,
@@ -279,13 +280,7 @@ export const createProjectsRouter = (getWindow: () => BrowserWindow | null) => {
 		getDefaultApp: publicProcedure
 			.input(z.object({ projectId: z.string() }))
 			.query(({ input }) => {
-				const project = localDb
-					.select()
-					.from(projects)
-					.where(eq(projects.id, input.projectId))
-					.get();
-
-				return project?.defaultApp ?? "cursor";
+				return resolveDefaultEditor(input.projectId);
 			}),
 
 		getRecents: publicProcedure.query((): Project[] => {

apps/desktop/src/lib/trpc/routers/settings/index.ts

@@ -1,7 +1,9 @@
 import {
 	BRANCH_PREFIX_MODES,
 	EXECUTION_MODES,
+	EXTERNAL_APPS,
 	FILE_OPEN_MODES,
+	NON_EDITOR_APPS,
 	settings,
 	TERMINAL_LINK_BEHAVIORS,
 	type TerminalPreset,
@@ -661,6 +663,35 @@ export const createSettingsRouter = () => {
 				return { success: true };
 			}),
 
+		getDefaultEditor: publicProcedure.query(() => {
+			const row = getSettings();
+			return row.defaultEditor ?? null;
+		}),
+
+		setDefaultEditor: publicProcedure
+			.input(
+				z.object({
+					editor: z
+						.enum(EXTERNAL_APPS)
+						.nullable()
+						.refine((val) => val === null || !NON_EDITOR_APPS.includes(val), {
+							message: "Non-editor apps cannot be set as the global default",
+						}),
+				}),
+			)
+			.mutation(({ input }) => {
+				localDb
+					.insert(settings)
+					.values({ id: 1, defaultEditor: input.editor })
+					.onConflictDoUpdate({
+						target: settings.id,
+						set: { defaultEditor: input.editor },
+					})
+					.run();
+
+				return { success: true };
+			}),
+
 		// TODO: remove telemetry procedures once telemetry_enabled column is dropped
 		getTelemetryEnabled: publicProcedure.query(() => {
 			return true;

apps/desktop/src/renderer/components/OpenInButton/OpenInButton.tsx

@@ -100,7 +100,7 @@ const ALL_APP_OPTIONS = [
 ];
 
 export const getAppOption = (id: ExternalApp) =>
-	ALL_APP_OPTIONS.find((app) => app.id === id) ?? APP_OPTIONS[1];
+	ALL_APP_OPTIONS.find((app) => app.id === id);
 
 export interface OpenInButtonProps {
 	path: string | undefined;
@@ -126,11 +126,10 @@ export function OpenInButton({
 	const showCopyPathShortcut =
 		showShortcuts && copyPathShortcut !== "Unassigned";
 
-	const { data: defaultApp = "cursor" } =
-		electronTrpc.projects.getDefaultApp.useQuery(
-			{ projectId: projectId as string },
-			{ enabled: !!projectId },
-		);
+	const { data: defaultApp } = electronTrpc.projects.getDefaultApp.useQuery(
+		{ projectId: projectId as string },
+		{ enabled: !!projectId },
+	);
 
 	const openInApp = electronTrpc.external.openInApp.useMutation({
 		onSuccess: () => {
@@ -141,7 +140,7 @@ export function OpenInButton({
 	});
 	const copyPath = electronTrpc.external.copyPath.useMutation();
 
-	const currentApp = getAppOption(defaultApp);
+	const currentApp = defaultApp ? (getAppOption(defaultApp) ?? null) : null;
 
 	const handleOpenIn = (app: ExternalApp) => {
 		if (!path) return;
@@ -156,13 +155,13 @@ export function OpenInButton({
 	};
 
 	const handleOpenLastUsed = () => {
-		if (!path) return;
+		if (!path || !defaultApp) return;
 		openInApp.mutate({ path, app: defaultApp, projectId });
 	};
 
 	return (
 		<ButtonGroup>
-			{label && (
+			{label && currentApp && (
 				<Tooltip>
 					<TooltipTrigger asChild>
 						<Button

apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/OpenInMenuButton/OpenInMenuButton.tsx

@@ -15,7 +15,7 @@ import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip";
 import { cn } from "@superset/ui/utils";
 import { memo, useCallback, useMemo } from "react";
 import { HiChevronDown } from "react-icons/hi2";
-import { LuCopy } from "react-icons/lu";
+import { LuCopy, LuExternalLink } from "react-icons/lu";
 import jetbrainsIcon from "renderer/assets/app-icons/jetbrains.svg";
 import vscodeIcon from "renderer/assets/app-icons/vscode.svg";
 import {
@@ -39,11 +39,10 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
 	projectId,
 }: OpenInMenuButtonProps) {
 	const utils = electronTrpc.useUtils();
-	const { data: defaultApp = "cursor" } =
-		electronTrpc.projects.getDefaultApp.useQuery(
-			{ projectId: projectId as string },
-			{ enabled: !!projectId, staleTime: 30000 },
-		);
+	const { data: defaultApp } = electronTrpc.projects.getDefaultApp.useQuery(
+		{ projectId: projectId as string },
+		{ enabled: !!projectId, staleTime: 30000 },
+	);
 	const openInApp = electronTrpc.external.openInApp.useMutation({
 		onSuccess: () => {
 			if (projectId) {
@@ -57,7 +56,10 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
 		onError: (error) => toast.error(`Failed to copy path: ${error.message}`),
 	});
 
-	const currentApp = useMemo(() => getAppOption(defaultApp), [defaultApp]);
+	const currentApp = useMemo(
+		() => (defaultApp ? (getAppOption(defaultApp) ?? null) : null),
+		[defaultApp],
+	);
 	const openInShortcut = useHotkeyText("OPEN_IN_APP");
 	const copyPathShortcut = useHotkeyText("COPY_PATH");
 	const showOpenInShortcut = openInShortcut !== "Unassigned";
@@ -66,6 +68,12 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
 
 	const handleOpenInEditor = useCallback(() => {
 		if (openInApp.isPending || copyPath.isPending) return;
+		if (!defaultApp) {
+			toast.error("No default editor configured", {
+				description: "Open a project in an editor first to set a default.",
+			});
+			return;
+		}
 		openInApp.mutate({ path: worktreePath, app: defaultApp, projectId });
 	}, [worktreePath, defaultApp, projectId, openInApp, copyPath.isPending]);
 
@@ -90,22 +98,31 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
 					<button
 						type="button"
 						onClick={handleOpenInEditor}
-						disabled={isLoading}
-						aria-label={`Open in ${currentApp.displayLabel ?? currentApp.label}`}
+						disabled={isLoading || !currentApp}
+						aria-label={
+							currentApp
+								? `Open in ${currentApp.displayLabel ?? currentApp.label}`
+								: "Open in editor"
+						}
 						className={cn(
 							"group flex items-center gap-1.5 h-6 px-1.5 sm:pl-1.5 sm:pr-2 rounded-l border border-r-0 border-border/60 bg-secondary/50 text-xs font-medium",
 							"transition-all duration-150 ease-out",
 							"hover:bg-secondary hover:border-border",
 							"focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring",
 							"active:scale-[0.98]",
 							isLoading && "opacity-50 pointer-events-none",
+							!currentApp && "opacity-50",
 						)}
 					>
-						<img
-							src={currentApp.icon}
-							alt=""
-							className="size-3.5 object-contain shrink-0"
-						/>
+						{currentApp ? (
+							<img
+								src={currentApp.icon}
+								alt=""
+								className="size-3.5 object-contain shrink-0"
+							/>
+						) : (
+							<LuExternalLink className="size-3.5 shrink-0" />
+						)}
 						{branch && (
 							<span className="hidden lg:inline text-muted-foreground truncate max-w-[140px] tabular-nums">
 								/{branch}
@@ -119,8 +136,10 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
 				<TooltipContent side="bottom" sideOffset={6}>
 					<div className="flex flex-col gap-1">
 						<span className="flex items-center gap-1.5">
-							Open in {currentApp.displayLabel ?? currentApp.label}
-							{showOpenInShortcut && (
+							{currentApp
+								? `Open in ${currentApp.displayLabel ?? currentApp.label}`
+								: "Select an editor from the dropdown"}
+							{currentApp && showOpenInShortcut && (
 								<kbd className="px-1 py-0.5 text-[10px] font-mono bg-foreground/10 text-foreground/70 rounded">
 									{openInShortcut}
 								</kbd>

apps/desktop/src/renderer/routes/_authenticated/_dashboard/workspace/$workspaceId/page.tsx

@@ -300,11 +300,10 @@ function WorkspacePage() {
 
 	// Open in last used app shortcut
 	const projectId = workspace?.projectId;
-	const { data: defaultApp = "cursor" } =
-		electronTrpc.projects.getDefaultApp.useQuery(
-			{ projectId: projectId as string },
-			{ enabled: !!projectId },
-		);
+	const { data: defaultApp } = electronTrpc.projects.getDefaultApp.useQuery(
+		{ projectId: projectId as string },
+		{ enabled: !!projectId },
+	);
 	const utils = electronTrpc.useUtils();
 	const openInApp = electronTrpc.external.openInApp.useMutation({
 		onSuccess: () => {
@@ -316,7 +315,7 @@ function WorkspacePage() {
 	useAppHotkey(
 		"OPEN_IN_APP",
 		() => {
-			if (workspace?.worktreePath) {
+			if (workspace?.worktreePath && defaultApp) {
 				openInApp.mutate({
 					path: workspace.worktreePath,
 					app: defaultApp,

apps/desktop/src/renderer/routes/_authenticated/settings/components/ClickablePath/ClickablePath.tsx

@@ -27,12 +27,18 @@ interface ClickablePathProps {
 	className?: string;
 }
 
-const defaultApp: ExternalApp = "cursor";
-
 export function ClickablePath({ path, className }: ClickablePathProps) {
 	const [isOpen, setIsOpen] = useState(false);
+	const utils = electronTrpc.useUtils();
+	// Uses global default editor (no project context on the settings page).
+	// No projectId is passed to openInApp, so per-project defaults are not affected.
+	const { data: defaultApp } =
+		electronTrpc.settings.getDefaultEditor.useQuery();
 
 	const openInApp = electronTrpc.external.openInApp.useMutation({
+		onSuccess: () => {
+			utils.settings.getDefaultEditor.invalidate();
+		},
 		onError: (error) => toast.error(`Failed to open: ${error.message}`),
 	});