fix(desktop): use execWithShellEnv for gh CLI in import from PR

[Kitenite]

Summary

• Fix gh CLI not being found when importing a PR on macOS (app launched from Finder/Dock)
• getPrInfo() was the only gh call using raw execFileAsync + getGitEnv(), which lacks the ENOENT retry logic that resolves the user's shell PATH
• Switch to execWithShellEnv, matching the pattern used by all other gh calls in the codebase

Changes

• apps/desktop/src/lib/trpc/routers/workspaces/utils/git.ts: Replace execFileAsync("gh", ...) with execWithShellEnv("gh", ...) in getPrInfo(), removing the now-unnecessary getGitEnv() call

Test Plan

• Launch the desktop app from Finder (not terminal) on macOS
• Import a PR via URL — verify it resolves the gh CLI and fetches PR info successfully
• Verify existing worktree creation and PR import flows still work end-to-end

Summary by CodeRabbit

• Refactor
  • Improved internal handling of Git operations for pull request information retrieval through enhanced environment variable management and simplified execution flow.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change replaces direct execFile calls with execWithShellEnv wrapper for PR info fetching in the Git utility module. The explicit environment construction via getGitEnv is removed, and environment parameter passing is eliminated from the getPrInfo call, relying on the wrapper to handle shell-environment configuration.

Changes

Cohort / File(s)	Summary
Git Environment Wrapper Migration apps/desktop/src/lib/trpc/routers/workspaces/utils/git.ts	Replaced direct execFileAsync usage with execWithShellEnv wrapper for PR info fetching; removed getGitEnv call and env parameter passing; updated imports/exports to reflect wrapper dependency. Timeout behavior preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(desktop): resolve gh CLI PATH issue when launched from Finder/Dock #591: Switches workspace command execution to the same execWithShellEnv wrapper, making related changes to CLI command invocation and environment handling patterns.
• create commit in change tab #409: Modifies getGitEnv logic that this PR removes from the call path, directly related through shared environment construction and shell PATH/env merging concerns.

Poem

🐰 A rabbit hops through wrapper's grace,
Environment flows without a trace,
No need to build what's done before,
Shell awareness at the core! ✨

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/fix-import-pr-user-path

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉