Skip to content

fix(desktop): stabilize workspace list item hover layout#1532

Merged
Kitenite merged 1 commit into
superset-sh:mainfrom
ascrazy:codex/stabilize-workspace-list-item-height
Feb 17, 2026
Merged

fix(desktop): stabilize workspace list item hover layout#1532
Kitenite merged 1 commit into
superset-sh:mainfrom
ascrazy:codex/stabilize-workspace-list-item-height

Conversation

@ascrazy
Copy link
Copy Markdown
Contributor

@ascrazy ascrazy commented Feb 16, 2026

Description

Stabilizes workspace row height in the desktop sidebar to prevent hover-time layout shifts.
The diff stats badge now keeps a fixed height and swaps between stats/close affordance using opacity instead of display toggling, which avoids text and neighboring row movement.

Changed file:

  • /Users/alexs/Dev/superset/apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceDiffStats.tsx

Related Issues

N/A

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

  • cd apps/desktop && SUPERSET_WORKSPACE_NAME=dev SKIP_ENV_VALIDATION=1 bun run dev
  • Hover workspace items with diff stats in sidebar
  • Confirm row label no longer shifts vertically and neighboring items do not move

Screenshots (if applicable)

Before After
ScreenRecording2026-02-16at22 20 46-ezgif com-video-to-gif-converter ezgif-11296725922c1e08

Additional Notes

This is a focused UI stability fix with no intended behavior changes outside hover layout consistency.

Summary by CodeRabbit

Release Notes

  • Style
    • Improved workspace diff statistics display with refined layout and spacing
    • Enhanced close button interaction—now transitions smoothly with opacity-based hover visibility
    • Refined hover behavior for better visual feedback and accessibility

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A single React component file is restructured to improve its layout and hover interaction behavior. CSS classes are reorganized for better sizing and positioning, and the close button's visibility model transitions from hidden/shown to opacity-based, with pointer-events management for interaction control.

Changes

Cohort / File(s) Summary
WorkspaceDiffStats UI Refactor
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceDiffStats.tsx
Restructured wrapper div classes for layout and height constraints; converted inner content container from group-hover:hidden to group-hover:opacity-0 with transition effects; repositioned close button to use absolute positioning with opacity-based visibility and pointer-events control on hover.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Hovers now drift soft and slow,
Buttons fade with gentle glow,
No more hiding, just fade away,
Opacity transitions save the day!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: stabilizing workspace list item hover layout to prevent layout shifts.
Description check ✅ Passed The description follows the template with all required sections completed: clear description of the change, related issues (N/A), type of change marked, testing steps provided, before/after screenshots included, and additional notes.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ascrazy ascrazy marked this pull request as ready for review February 16, 2026 21:25
@Kitenite Kitenite merged commit e9ca6ce into superset-sh:main Feb 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants