Skip to content

fix(desktop): skip self-copy in canary Linux updater manifest step#1493

Merged
Kitenite merged 1 commit into
mainfrom
kitenite/fix-linux-build-release
Feb 14, 2026
Merged

fix(desktop): skip self-copy in canary Linux updater manifest step#1493
Kitenite merged 1 commit into
mainfrom
kitenite/fix-linux-build-release

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Feb 14, 2026

Summary

  • Fix canary release workflow failing on Linux with cp: 'latest-linux.yml' and 'latest-linux.yml' are the same file
  • The *-linux.yml glob matched latest-linux.yml itself, then tried to copy it to itself

Changes

  • Add guards to skip canary-linux.yml and latest-linux.yml in the glob loop so only the versioned source file (e.g. Superset-0.0.1-canary.20260214-linux.yml) gets copied
  • Matches the pattern already used in release-desktop.yml

Test Plan

  • Trigger a canary release via workflow_dispatch and verify the "Create canary-named copies" step passes

Summary by CodeRabbit

  • Chores
    • Improved the release workflow configuration to prevent redundant operations and better document file origins during the canary release process.

The *-linux.yml glob matched latest-linux.yml itself, causing
`cp "latest-linux.yml" "latest-linux.yml"` to fail on Linux.
Add guards to only process the versioned source file.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The canary release workflow's file-copying loop is refined to skip canary-linux.yml and latest-linux.yml files, only process existing source files, and include source file names in logging output. This prevents self-referential manifest copying and improves operational clarity.

Changes

Cohort / File(s) Summary
Canary Release Workflow
.github/workflows/release-desktop-canary.yml
Modified file-copy loop to exclude specific manifest files (canary-linux.yml, latest-linux.yml), add existence checks, and enhance logging with source file identification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Hopping through workflows so fine,
No more circles in manifest line,
Files that copy themselves say "nope!"
With better logs, we can see where things came from—
Organized chaos, now a well-planned warren! 🏠

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kitenite/fix-linux-build-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit cc891c3 into main Feb 14, 2026
6 of 7 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 14, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Fly.io Streams (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

@Kitenite Kitenite deleted the kitenite/fix-linux-build-release branch February 16, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant