fix(desktop): skip self-copy in canary Linux updater manifest step#1493
Conversation
The *-linux.yml glob matched latest-linux.yml itself, causing `cp "latest-linux.yml" "latest-linux.yml"` to fail on Linux. Add guards to only process the versioned source file.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe canary release workflow's file-copying loop is refined to skip canary-linux.yml and latest-linux.yml files, only process existing source files, and include source file names in logging output. This prevents self-referential manifest copying and improves operational clarity. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Summary
cp: 'latest-linux.yml' and 'latest-linux.yml' are the same file*-linux.ymlglob matchedlatest-linux.ymlitself, then tried to copy it to itselfChanges
canary-linux.ymlandlatest-linux.ymlin the glob loop so only the versioned source file (e.g.Superset-0.0.1-canary.20260214-linux.yml) gets copiedrelease-desktop.ymlTest Plan
workflow_dispatchand verify the "Create canary-named copies" step passesSummary by CodeRabbit