-
Notifications
You must be signed in to change notification settings - Fork 909
chore(setup): workspace dev data path + DB seed + force flags #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,3 +84,4 @@ apps/streams/data/ | |
|
|
||
| # Generated by setup.sh | ||
| Caddyfile | ||
| superset-dev-data/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * Maps incoming event types to canonical lifecycle events. | ||
| * Handles variations from different agent CLIs. | ||
| * | ||
| * Returns null for unknown events so callers can ignore safely | ||
| * for forward compatibility. | ||
| */ | ||
| export function mapEventType( | ||
| eventType: string | undefined, | ||
| ): "Start" | "Stop" | "PermissionRequest" | null { | ||
| if (!eventType) { | ||
| return null; | ||
| } | ||
| if (eventType === "Start" || eventType === "UserPromptSubmit") { | ||
| return "Start"; | ||
| } | ||
| if (eventType === "PermissionRequest") { | ||
| return "PermissionRequest"; | ||
| } | ||
| if (eventType === "Stop" || eventType === "agent-turn-complete") { | ||
| return "Stop"; | ||
| } | ||
| return null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--forcewith no source DB deletessuperset-dev-data/without recreating it.When
--forceis set but$HOME/.superset/local.dbdoesn't exist, the directory is removed (line 523) and then the function returns early at line 532 without callingmkdir -p(line 541). Downstream code or the app expectingsuperset-dev-data/to exist could fail.Consider ensuring the directory is recreated even when skipping the seed:
Proposed fix
if [ ! -f "$source_db" ]; then warn "No source local.db found at $source_db — skipping (app will create a fresh one)" + mkdir -p "$dev_data_dir" + chmod 700 "$dev_data_dir" step_skipped "Seed local DB (no source DB)" return 0 fi📝 Committable suggestion
🤖 Prompt for AI Agents