chore(desktop): remove Claude binary from build pipeline#1487
Conversation
The Claude Code binary is no longer bundled into the app. The SDK resolves the binary at runtime instead. The chat gracefully handles a missing binary by omitting pathToClaudeCodeExecutable and letting the SDK find it on its own.
📝 WalkthroughWalkthroughThese changes shift Claude binary handling from build-time bundling to runtime resolution. The electron-builder configuration no longer bundles the platform-specific binary, the build scripts no longer download it, and runtime code now validates binary existence before use. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Changes
apps/desktop/package.json: Removeddownload:claudefromprebuildandprepackagehooksapps/desktop/electron-builder.ts: Commented out the Claude binaryextraResourcesentryapps/desktop/.../agent-execution.ts:getClaudeBinaryPath()returnsnullwhen binary doesn't exist;pathToClaudeCodeExecutableis omitted so the SDK resolves it on its ownbun.lock: Version bump reflectedTest Plan
bun run typecheckpasses inapps/desktopbun run buildinapps/desktopsucceeds without downloading the Claude binarySummary by CodeRabbit