chore(electric-proxy): local dev setup and worker cleanup#1464
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe electric-proxy application extracts its environment configuration interface to a dedicated file and refactors the main module to import it. Additionally, the logic for handling the ELECTRIC_SECRET parameter is updated to be conditional—it is only included in query parameters when present. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…secret optional Move Env interface to dedicated env.ts file. Enable Cloudflare observability. Make ELECTRIC_SECRET optional for local dev without it.
saddlepaddle
force-pushed
the
fix/electric-proxy-local-dev
branch
from
af99d81 to
d6b33bf
Compare
5 tasks
AviPeltz
added a commit
that referenced
this pull request
Apr 18, 2026
Observability was enabled in #1464 but dropped when the proxy was re-created from scratch in #1867. Without it, every wrangler deploy reconciles Cloudflare back to logs/traces off, which is why the dashboard toggles kept reverting after each production deploy. Pin invocation_logs explicitly so future config drift can't silently disable it again. Audit logs are an account-level setting and still need to be re-enabled in the Cloudflare dashboard separately.
4 tasks
AviPeltz
added a commit
that referenced
this pull request
Apr 18, 2026
…3565) Observability was enabled in #1464 but dropped when the proxy was re-created from scratch in #1867. Without it, every wrangler deploy reconciles Cloudflare back to logs/traces off, which is why the dashboard toggles kept reverting after each production deploy. Pin invocation_logs explicitly so future config drift can't silently disable it again. Audit logs are an account-level setting and still need to be re-enabled in the Cloudflare dashboard separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun dev(wrangler dev, Caddy HTTP/2 proxy, .dev.vars generation)Envinterface to dedicated file, enable Cloudflare observabilityELECTRIC_SECREToptional for local devChanges
.superset/setup.sh— Generateapps/electric-proxy/.dev.varswith local Electric/auth URLs; Caddy now reverse-proxies wrangler dev instead of the API server; addELECTRIC_PROXY_PORTandCADDY_ELECTRIC_PORTpackage.json— Include@superset/electric-proxyinbun devturbo.jsonc— AddNEXT_PUBLIC_ELECTRIC_URLandELECTRIC_PROXY_PORTto global envapps/electric-proxy/package.json— Dev script reads port from.envvia dotenvapps/electric-proxy/src/env.ts— ExtractedEnvinterfaceapps/electric-proxy/src/index.ts— Import from env.ts, make secret conditionalapps/electric-proxy/wrangler.jsonc— Bump compat date, enable observability.gitignore— Ignore.dev.varsTest Plan
.superset/setup.sh— verify.dev.varsgenerated inapps/electric-proxy/bun dev— verify electric-proxy starts alongside other servicesSummary by CodeRabbit
Release Notes
Bug Fixes
Chores