feat(desktop): redesign environment variables table #1420
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1001,6 +1001,17 @@ export const createProjectsRouter = (getWindow: () => BrowserWindow | null) => { | |
| return { success: true, terminalWarning }; | ||
| }), | ||
|
|
||
| linkToNeon: publicProcedure | ||
| .input(z.object({ id: z.string(), neonProjectId: z.string() })) | ||
| .mutation(({ input }) => { | ||
| localDb | ||
| .update(projects) | ||
| .set({ neonProjectId: input.neonProjectId }) | ||
| .where(eq(projects.id, input.id)) | ||
| .run(); | ||
| return { success: true }; | ||
| }), | ||
|
Comment on lines
+1004
to
+1013
Contributor
There was a problem hiding this comment. Missing project existence check — silently succeeds for invalid IDs. Every other mutation in this router that updates by Also, Proposed fix linkToNeon: publicProcedure
- .input(z.object({ id: z.string(), neonProjectId: z.string() }))
+ .input(z.object({ id: z.string(), neonProjectId: z.string().min(1) }))
.mutation(({ input }) => {
+ const project = localDb
+ .select()
+ .from(projects)
+ .where(eq(projects.id, input.id))
+ .get();
+
+ if (!project) {
+ throw new TRPCError({
+ code: "NOT_FOUND",
+ message: `Project ${input.id} not found`,
+ });
+ }
+
localDb
.update(projects)
.set({ neonProjectId: input.neonProjectId })
.where(eq(projects.id, input.id))
.run();
return { success: true };
}),As per coding guidelines, "Use appropriate TRPCError codes consistently: NOT_FOUND (resource doesn't exist)" and "Follow existing patterns in the codebase and match the codebase style rather than introducing novel patterns". 🤖 Prompt for AI Agents |
||
|
|
||
| getGitHubAvatar: publicProcedure | ||
| .input(z.object({ id: z.string() })) | ||
| .query(async ({ input }) => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ import type { | |
| SelectInvitation, | ||
| SelectMember, | ||
| SelectOrganization, | ||
| SelectProject, | ||
| SelectSubscription, | ||
| SelectTask, | ||
| SelectTaskStatus, | ||
|
|
@@ -38,7 +38,7 @@ type ApiKeyDisplay = z.infer<typeof apiKeyDisplaySchema>; | |
| interface OrgCollections { | ||
| tasks: Collection<SelectTask>; | ||
| taskStatuses: Collection<SelectTaskStatus>; | ||
| projects: Collection<SelectProject>; | ||
| members: Collection<SelectMember>; | ||
| users: Collection<SelectUser>; | ||
| invitations: Collection<SelectInvitation>; | ||
|
|
@@ -142,29 +142,19 @@ function createOrgCollections(organizationId: string): OrgCollections { | |
| }), | ||
| ); | ||
|
|
||
| const projects = createCollection( | ||
| electricCollectionOptions<SelectProject>({ | ||
| id: `projects-${organizationId}`, | ||
| shapeOptions: { | ||
| url: electricUrl, | ||
| params: { | ||
| table: "projects", | ||
| organizationId, | ||
| }, | ||
| headers, | ||
| columnMapper, | ||
| }, | ||
| getKey: (item) => item.id, | ||
| }), | ||
| ); | ||
|
|
||
|
|
@@ -315,7 +305,7 @@ function createOrgCollections(organizationId: string): OrgCollections { | |
| return { | ||
| tasks, | ||
| taskStatuses, | ||
| projects, | ||
| members, | ||
| users, | ||
| invitations, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 346
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 4734
Remove
SECRETS_ENCRYPTION_KEYfrom Admin app deployment environment.The Admin app's env schema (
apps/admin/src/env.ts) does not includeSECRETS_ENCRYPTION_KEY, and no code in the Admin app references it. The key is only used by the API app's secrets management router. Passing unused secrets violates the least-privilege principle.🤖 Prompt for AI Agents