ci(desktop): verify app-update.yml in build pipeline

[Kitenite]

Summary

• The split build change in ci(desktop): use macos-latest-xlarge runner for faster builds #1372 (--dir + --prepackaged) caused app-update.yml to be missing from the app bundle, breaking auto-update for canary builds
• ci(desktop): use macos-latest-xlarge runner for faster builds #1372 was reverted in [bug] pasting images into codex doesn't work, but claude code does #1393. This PR adds a CI guard so the same class of issue is caught before shipping

Changes

• Add a verification step after electron-builder that fails the build if app-update.yml is missing from the .app bundle's Resources directory

Test Plan

• Canary build passes with the verification step
• Verify auto-update works on next canary release

Summary by CodeRabbit

Release Notes

• Chores
  • Enhanced macOS build process with stricter validation to ensure all required build artifacts are present before release, improving build reliability.

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ✅ Neon database branch
• ✅ Electric Fly.io app
• ✅ Streams Fly.io app

Thank you for your contribution! 🎉

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a verification step to the macOS build workflow that checks for the existence of app-update.yml within the built .app bundle. The workflow fails with an error message if the file is missing, ensuring consistency in the build artifacts.

Changes

Cohort / File(s)	Summary
Build Workflow Verification .github/workflows/build-desktop.yml	Introduces a new step "Verify app-update.yml exists" that locates the built .app bundle under release/mac-arm64 and validates the presence of app-update.yml at PATH/Contents/Resources/app-update.yml. Workflow fails immediately if validation fails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(desktop): add canary build workflow for internal testing #721: Adds manifest upload logic for update artifacts, directly complementary to this verification step that ensures the manifest exists before downstream processing.
• add auto update #203: Modifies CI workflow artifact handling for app-update.yml and auto-update runtime, sharing the same update manifest validation scope.
• fix(desktop): add timestamp to canary versions for autoupdate #734: Changes version suffix inputs to build-desktop.yml, affecting workflow behavior alongside this new verification logic.

Poem

🐰 A rabbit hops through workflows with glee,
Checking that updates are where they should be,
app-update.yml in Resources it finds,
No broken builds left in our wake behind,
Quality assured with each careful hop! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a verification step for app-update.yml in the desktop CI build pipeline.
Description check	✅ Passed	The description provides clear context, explains the problem being solved, and includes a test plan, though some template sections are not fully addressed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/canary-update

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

.github/workflows/build-desktop.yml (1)

108-115: Hardcoded mac-arm64 path should use the matrix variable.

The path release/mac-arm64 is hardcoded, but the matrix defines arch on line 40. If x64 is ever added to the matrix, this step would check the wrong directory.

♻️ Suggested fix

       - name: Verify app-update.yml exists
         working-directory: apps/desktop
         run: |
-          APP_DIR=$(ls -d release/mac-arm64/*.app | head -1)
+          APP_DIR=$(ls -d release/mac-${{ matrix.arch }}/*.app | head -1)
           test -f "$APP_DIR/Contents/Resources/app-update.yml" || {
             echo "::error::app-update.yml missing from $APP_DIR/Contents/Resources/ — auto-update will be broken"
             exit 1
           }

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}