feat(desktop): add project icon support with custom protocol

apps/desktop/src/lib/trpc/routers/projects/projects.ts

@@ -14,6 +14,10 @@ import type { BrowserWindow } from "electron";
 import { dialog } from "electron";
 import { track } from "main/lib/analytics";
 import { localDb } from "main/lib/local-db";
+import {
+	deleteProjectIcon,
+	saveProjectIconFromDataUrl,
+} from "main/lib/project-icons";
 import { getWorkspaceRuntimeRegistry } from "main/lib/workspace-runtime";
 import { PROJECT_COLOR_VALUES } from "shared/constants/project-colors";
 import simpleGit from "simple-git";
@@ -34,6 +38,7 @@ import {
 	sanitizeAuthorPrefix,
 } from "../workspaces/utils/git";
 import { getDefaultProjectColor } from "./utils/colors";
+import { discoverAndSaveProjectIcon } from "./utils/favicon-discovery";
 import { fetchGitHubOwner, getGitHubAvatarUrl } from "./utils/github";
 
 type Project = SelectProject;
@@ -1054,6 +1059,90 @@ export const createProjectsRouter = (getWindow: () => BrowserWindow | null) => {
 					prefix: sanitizeAuthorPrefix(authorName),
 				};
 			}),
+
+		triggerFaviconDiscovery: publicProcedure
+			.input(z.object({ id: z.string() }))
+			.mutation(async ({ input }) => {
+				const project = localDb
+					.select()
+					.from(projects)
+					.where(eq(projects.id, input.id))
+					.get();
+
+				if (!project) {
+					throw new TRPCError({
+						code: "NOT_FOUND",
+						message: `Project ${input.id} not found`,
+					});
+				}
+
+				// Skip if the project already has an icon
+				if (project.iconUrl) {
+					return { iconUrl: project.iconUrl };
+				}
+
+				const iconUrl = await discoverAndSaveProjectIcon({
+					projectId: project.id,
+					repoPath: project.mainRepoPath,
+				});
+
+				if (iconUrl) {
+					localDb
+						.update(projects)
+						.set({ iconUrl })
+						.where(eq(projects.id, input.id))
+						.run();
+				}
+
+				return { iconUrl };
+			}),
+
+		setProjectIcon: publicProcedure
+			.input(
+				z.object({
+					id: z.string(),
+					icon: z.string().nullable(),
+				}),
+			)
+			.mutation(async ({ input }) => {
+				const project = localDb
+					.select()
+					.from(projects)
+					.where(eq(projects.id, input.id))
+					.get();
+
+				if (!project) {
+					throw new TRPCError({
+						code: "NOT_FOUND",
+						message: `Project ${input.id} not found`,
+					});
+				}
+
+				if (input.icon === null) {
+					// Remove icon
+					deleteProjectIcon(input.id);
+					localDb
+						.update(projects)
+						.set({ iconUrl: null })
+						.where(eq(projects.id, input.id))
+						.run();
+					return { iconUrl: null };
+				}
+
+				// Save icon from data URL
+				const iconUrl = await saveProjectIconFromDataUrl({
+					projectId: input.id,
+					dataUrl: input.icon,
+				});
+
+				localDb
+					.update(projects)
+					.set({ iconUrl })
+					.where(eq(projects.id, input.id))
+					.run();
+
+				return { iconUrl };
+			}),
 	});
 };
 

apps/desktop/src/lib/trpc/routers/projects/utils/favicon-discovery.ts

@@ -0,0 +1,86 @@
+import { readFile, stat } from "node:fs/promises";
+import { extname } from "node:path";
+import fg from "fast-glob";
+import {
+	saveProjectIconFromBuffer,
+	saveProjectIconFromFile,
+} from "main/lib/project-icons";
+
+/** Common favicon file names to search for in project roots */
+const FAVICON_PATTERNS = [
+	"favicon.ico",
+	"favicon.png",
+	"favicon.svg",
+	"logo.png",
+	"logo.svg",
+	"icon.png",
+	"icon.svg",
+	".github/logo.png",
+	".github/logo.svg",
+	"public/favicon.ico",
+	"public/favicon.png",
+	"public/favicon.svg",
+	"public/logo.png",
+	"public/logo.svg",
+	"static/favicon.ico",
+	"static/favicon.png",
+	"static/favicon.svg",
+	"assets/favicon.ico",
+	"assets/favicon.png",
+	"assets/icon.png",
+];
+
+/** Max file size for discovered favicons: 256KB */
+const MAX_FAVICON_SIZE = 256 * 1024;
+
+/**
+ * Discovers a favicon/icon in the project directory and saves it to disk.
+ * Returns the protocol URL if found, or null if no icon was discovered.
+ */
+export async function discoverAndSaveProjectIcon({
+	projectId,
+	repoPath,
+}: {
+	projectId: string;
+	repoPath: string;
+}): Promise<string | null> {
+	try {
+		const matches = await fg(FAVICON_PATTERNS, {
+			cwd: repoPath,
+			absolute: true,
+			ignore: ["**/node_modules/**", "**/.git/**", "**/dist/**", "**/build/**"],
+			onlyFiles: true,
+		});
+
+		if (matches.length === 0) return null;
+
+		// Use the first match (ordered by FAVICON_PATTERNS priority)
+		const iconPath = matches[0];
+
+		// Check file size
+		const fileStat = await stat(iconPath);
+		if (fileStat.size > MAX_FAVICON_SIZE) {
+			console.log(
+				`[favicon-discovery] Icon too large (${Math.round(fileStat.size / 1024)}KB): ${iconPath}`,
+			);
+			return null;
+		}
+
+		const ext = extname(iconPath).replace(".", "") || "png";
+
+		// For .ico files, read as buffer since they may need special handling
+		if (ext === "ico") {
+			const buffer = await readFile(iconPath);
+			return await saveProjectIconFromBuffer({
+				projectId,
+				buffer: Buffer.from(buffer),
+				ext: "ico",
+			});
+		}
+
+		return await saveProjectIconFromFile({ projectId, sourcePath: iconPath });
+	} catch (error) {
+		console.error("[favicon-discovery] Error discovering icon:", error);
+		return null;
+	}
+}

apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts

@@ -160,6 +160,7 @@ export const createQueryProcedures = () => {
 						githubOwner: string | null;
 						mainRepoPath: string;
 						hideImage: boolean;
+						iconUrl: string | null;
 					};
 					workspaces: Array<{
 						id: string;
@@ -190,6 +191,7 @@ export const createQueryProcedures = () => {
 						githubOwner: project.githubOwner ?? null,
 						mainRepoPath: project.mainRepoPath,
 						hideImage: project.hideImage ?? false,
+						iconUrl: project.iconUrl ?? null,
 					},
 					workspaces: [],
 				});

apps/desktop/src/main/index.ts

@@ -1,6 +1,7 @@
 import path from "node:path";
+import { pathToFileURL } from "node:url";
 import { settings } from "@superset/local-db";
-import { app, BrowserWindow, dialog } from "electron";
+import { app, BrowserWindow, dialog, net, protocol, session } from "electron";
 import { makeAppSetup } from "lib/electron-app/factories/app/setup";
 import {
 	handleAuthCallback,
@@ -11,6 +12,7 @@ import { setupAgentHooks } from "./lib/agent-setup";
 import { initAppState } from "./lib/app-state";
 import { setupAutoUpdater } from "./lib/auto-updater";
 import { localDb } from "./lib/local-db";
+import { ensureProjectIconsDir, getProjectIconPath } from "./lib/project-icons";
 import { initSentry } from "./lib/sentry";
 import { reconcileDaemonSessions } from "./lib/terminal";
 import { disposeTray, initTray } from "./lib/tray";
@@ -210,6 +212,19 @@ if (process.env.NODE_ENV === "development") {
 	parentCheckInterval.unref();
 }
 
+// Register superset-icon:// protocol for serving project icons from disk
+protocol.registerSchemesAsPrivileged([
+	{
+		scheme: "superset-icon",
+		privileges: {
+			standard: true,
+			secure: true,
+			bypassCSP: true,
+			supportFetchAPI: true,
+		},
+	},
+]);
+
 // Single instance lock - required for second-instance event on Windows/Linux
 const gotTheLock = app.requestSingleInstanceLock();
 
@@ -229,6 +244,25 @@ if (!gotTheLock) {
 	(async () => {
 		await app.whenReady();
 
+		// Register protocol handler for superset-icon:// URLs
+		// Must register on BOTH default session and the app's custom partition
+		const iconProtocolHandler = (request: Request) => {
+			const url = new URL(request.url);
+			// superset-icon://projects/{projectId} → file on disk
+			const projectId = url.pathname.replace(/^\//, "");
+			const iconPath = getProjectIconPath(projectId);
+			if (!iconPath) {
+				return new Response("Not found", { status: 404 });
+			}
+			return net.fetch(pathToFileURL(iconPath).toString());
+		};
+		protocol.handle("superset-icon", iconProtocolHandler);
+		session
+			.fromPartition("persist:superset")
+			.protocol.handle("superset-icon", iconProtocolHandler);
+
+		ensureProjectIconsDir();
+
 		initSentry();
 
 		await initAppState();