fix(ci): fix streams preview deploy Dockerfile path doubling#1363
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughReplaces the preview workflow's single action with explicit setup and flyctl CLI steps (app create, secrets staging, deploy), updates production deploy to include repo-root context ( Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as "GitHub Actions Runner"
participant Flyctl as "flyctl (CLI)"
participant Flyio as "Fly.io API"
Runner->>Runner: checkout repo
Runner->>Flyctl: setup-flyctl action installs flyctl
Runner->>Flyctl: flyctl apps create <app> || true
Flyctl->>Flyio: Create app request (tolerant)
Runner->>Flyctl: flyctl secrets set ... --stage <stage>
Flyctl->>Flyio: Stage secrets
Runner->>Flyctl: flyctl deploy . --config apps/streams/fly.toml --app <app> --region <rgn> --remote-only
Flyctl->>Flyio: Deploy request (with repo-root context)
Flyio-->>Flyctl: Deployment status
Flyctl-->>Runner: Exit code / result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
ec1fd54 to
67f6514
Compare
67f6514 to
d26ae81
Compare
d26ae81 to
2f2116b
Compare
2f2116b to
af12a17
Compare
- Replace fly-pr-review-apps action with direct flyctl commands (the action doubled the Dockerfile path: apps/streams/apps/streams/Dockerfile) - Fix fly.toml dockerfile path to be relative to config directory - Add missing workspace deps (durable-session, ui, shared) to Dockerfile - Drop --frozen-lockfile since Docker builds use a workspace subset - Also fix production deploy with explicit build context
- Add missing STREAMS_INTERNAL_PORT and STREAMS_INTERNAL_URL env vars to fly.toml - Restructure Dockerfile to copy source files explicitly instead of whole directories, preventing host node_modules (linker=isolated) from overwriting container deps - Install deps after source copy so bun install results aren't overwritten - Copy apps/streams/node_modules to runtime stage for workspace package resolution - Add volume creation step to preview workflow for stream_data mount
…attern - Switch preview from manual flyctl commands to fly-pr-review-apps action - Add proper step names to production workflow for consistency
Summary
superfly/fly-pr-review-appsaction with directflyctlcommands for streams preview deployment — the action resolved the Dockerfile path relative to the config file directory, doubling it (apps/streams/apps/streams/Dockerfile)fly.tomldockerfile path to be relative to its own directorydurable-session,ui,shared) to Dockerfile for the new session-based auth--frozen-lockfilesince Docker builds use a workspace subsetTest plan